Image trigger test was mutating the wrong object

smarterclayton · smarterclayton · commit 976ebcb97624 · 2017-11-28T15:47:54.000-05:00
diff --git a/pkg/image/controller/trigger/image_trigger_controller_test.go b/pkg/image/controller/trigger/image_trigger_controller_test.go
@@ -958,7 +958,7 @@ func updateBuildConfigImages(bc *buildapi.BuildConfig, tagRetriever trigger.TagR
 		if updated == nil {
 			updated = bc.DeepCopy()
 		}
-		p = bc.Spec.Triggers[i].ImageChange
+		p = updated.Spec.Triggers[i].ImageChange
 		p.LastTriggeredImageID = latest
 	}
 	return updated, nil

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ func updateBuildConfigImages(bc *buildapi.BuildConfig, tagRetriever trigger.TagR`
`958`	`958`	`if updated == nil {`
`959`	`959`	`updated = bc.DeepCopy()`
`960`	`960`	`}`
`961`		`- p = bc.Spec.Triggers[i].ImageChange`
	`961`	`+ p = updated.Spec.Triggers[i].ImageChange`
`962`	`962`	`p.LastTriggeredImageID = latest`
`963`	`963`	`}`
`964`	`964`	`return updated, nil`