generate build state events

Author: bparees

pkg/build/api/types.go

@@ -63,6 +63,31 @@ const (
 	// forces the build to be processed by the build controller queue without waiting
 	// for a resync.
 	BuildAcceptedAnnotation = "build.openshift.io/accepted"
+
+	// BuildCreatedEvent is the reason associated with the event registered when a build is created.
+	BuildCreatedEventReason = "BuildCreated"
+	// BuildCreatedEventMessage is the message associatd with the event registered when a build is created.
+	BuildCreatedEventMessage = "Build %s/%s has been created"
+	// BuildStartedEvent is the reason associated with the event registered when a build is started (pod is created).
+	BuildStartedEventReason = "BuildStarted"
+	// BuildStartedEvent is the message associated with the event registered when a build is started (pod is created).
+	BuildStartedEventMessage = "Pod has been created to run build %s/%s"
+	// BuildRunningEvent is the reason associated with the event registered when the build pod starts running.
+	BuildRunningEventReason = "BuildRunning"
+	// BuildRunningEvent is the message associated with the event registered when the build pod starts running.
+	BuildRunningEventMessage = "Pod for build %s/%s started running"
+	// BuildCompletedEvent is the reason associated with the event registered when build completes successfully.
+	BuildCompletedEventReason = "BuildCompleted"
+	// BuildCompletedEvent is the message associated with the event registered when build completes successfully.
+	BuildCompletedEventMessage = "Build %s/%s completed successfully"
+	// BuildFailedEvent is the reason associated with the event registered when build fails.
+	BuildFailedEventReason = "BuildFailed"
+	// BuildFailedEvent is the message associated with the event registered when build fails.
+	BuildFailedEventMessage = "Build %s/%s failed"
+	// BuildCancelledEvent is the reason associated with the event registered when build is cancelled.
+	BuildCancelledEventReason = "BuildCancelled"
+	// BuildCancelledEvent is the message associated with the event registered when build is cancelled.
+	BuildCancelledEventMessage = "Build %s/%s has been cancelled"
 )
 
 // +genclient=true

pkg/build/client/clients.go

@@ -37,6 +37,11 @@ func (c OSClientBuildConfigClient) Update(buildConfig *buildapi.BuildConfig) err
 	return err
 }
 
+// BuildGetter provides methods for getting existing Builds.
+type BuildGetter interface {
+	Get(namespace, name string) (*buildapi.Build, error)
+}
+
 // BuildUpdater provides methods for updating existing Builds.
 type BuildUpdater interface {
 	Update(namespace string, build *buildapi.Build) error
@@ -47,7 +52,7 @@ type BuildLister interface {
 	List(namespace string, opts kapi.ListOptions) (*buildapi.BuildList, error)
 }
 
-// OSClientBuildClient deletes build create and update operations to the OpenShift client interface
+// OSClientBuildClient delegates build create and update operations to the OpenShift client interface
 type OSClientBuildClient struct {
 	Client osclient.Interface
 }
@@ -57,6 +62,11 @@ func NewOSClientBuildClient(client osclient.Interface) *OSClientBuildClient {
 	return &OSClientBuildClient{Client: client}
 }
 
+// Get returns a Build using the OpenShift client.
+func (c OSClientBuildClient) Get(namespace, name string) (*buildapi.Build, error) {
+	return c.Client.Builds(namespace).Get(name)
+}
+
 // Update updates builds using the OpenShift client.
 func (c OSClientBuildClient) Update(namespace string, build *buildapi.Build) error {
 	_, e := c.Client.Builds(namespace).Update(build)

pkg/build/controller/buildpod/controller.go

@@ -11,6 +11,7 @@ import (
 	"k8s.io/kubernetes/pkg/client/cache"
 	kclientset "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"
 	kcoreclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion"
+	"k8s.io/kubernetes/pkg/client/record"
 	kcontroller "k8s.io/kubernetes/pkg/controller"
 	utilruntime "k8s.io/kubernetes/pkg/util/runtime"
 	"k8s.io/kubernetes/pkg/util/wait"
@@ -49,16 +50,22 @@ type BuildPodController struct {
 	podStoreSynced   func() bool
 
 	runPolicies []policy.RunPolicy
+
+	recorder record.EventRecorder
 }
 
 // NewBuildPodController creates a new BuildPodController.
 func NewBuildPodController(buildInformer, podInformer cache.SharedIndexInformer, kc kclientset.Interface, oc osclient.Interface) *BuildPodController {
+	eventBroadcaster := record.NewBroadcaster()
+	eventBroadcaster.StartRecordingToSink(&kcoreclient.EventSinkImpl{Interface: kc.Core().Events("")})
+
 	buildListerUpdater := buildclient.NewOSClientBuildClient(oc)
 	c := &BuildPodController{
 		buildUpdater: buildListerUpdater,
 		secretClient: kc.Core(), // TODO: Replace with cache client
 		podClient:    kc.Core(),
 		queue:        workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()),
+		recorder:     eventBroadcaster.NewRecorder(kapi.EventSource{Component: "build-pod-controller"}),
 	}
 
 	c.runPolicies = policy.GetAllRunPolicies(buildListerUpdater, buildListerUpdater)
@@ -197,6 +204,7 @@ func (bc *BuildPodController) HandlePod(pod *kapi.Pod) error {
 		if build.Status.Phase == buildapi.BuildPhaseRunning {
 			now := unversioned.Now()
 			build.Status.StartTimestamp = &now
+			bc.recorder.Eventf(build, kapi.EventTypeNormal, buildapi.BuildRunningEventReason, fmt.Sprintf(buildapi.BuildRunningEventMessage, build.Namespace, build.Name))
 		}
 	}
 
@@ -218,6 +226,12 @@ func (bc *BuildPodController) HandlePod(pod *kapi.Pod) error {
 	// handle completion for it.  otherwise ignore it because we've already
 	// handled its completion previously.
 	if !buildWasComplete && buildutil.IsBuildComplete(build) {
+		switch build.Status.Phase {
+		case buildapi.BuildPhaseComplete:
+			bc.recorder.Eventf(build, kapi.EventTypeNormal, buildapi.BuildCompletedEventReason, fmt.Sprintf(buildapi.BuildCompletedEventMessage, build.Namespace, build.Name))
+		case buildapi.BuildPhaseError, buildapi.BuildPhaseFailed:
+			bc.recorder.Eventf(build, kapi.EventTypeNormal, buildapi.BuildFailedEventReason, fmt.Sprintf(buildapi.BuildFailedEventMessage, build.Namespace, build.Name))
+		}
 		common.HandleBuildCompletion(build, bc.runPolicies)
 	}
 
@@ -259,6 +273,8 @@ func (bc *BuildPodController) HandleBuildPodDeletion(pod *kapi.Pod) error {
 		build.Status.Reason = buildapi.StatusReasonBuildPodDeleted
 		build.Status.Message = buildapi.StatusMessageBuildPodDeleted
 		common.SetBuildCompletionTimeAndDuration(build)
+		bc.recorder.Eventf(build, kapi.EventTypeNormal, buildapi.BuildFailedEventReason, fmt.Sprintf(buildapi.BuildFailedEventMessage, build.Namespace, build.Name))
+
 		if err := bc.buildUpdater.Update(build.Namespace, build); err != nil {
 			return fmt.Errorf("Failed to update build %s/%s: %v", build.Namespace, build.Name, err)
 		}

pkg/build/controller/controller.go

@@ -72,6 +72,7 @@ func (bc *BuildController) CancelBuild(build *buildapi.Build) error {
 
 	build.Status.Phase = buildapi.BuildPhaseCancelled
 	common.SetBuildCompletionTimeAndDuration(build)
+	bc.Recorder.Eventf(build, kapi.EventTypeNormal, buildapi.BuildCancelledEventReason, fmt.Sprintf(buildapi.BuildCancelledEventMessage, build.Namespace, build.Name))
 	// set the status details for the cancelled build before updating the build
 	// object.
 	build.Status.Reason = buildapi.StatusReasonCancelledBuild
@@ -219,8 +220,9 @@ func (bc *BuildController) nextBuildPhase(build *buildapi.Build) error {
 		build.Status.Message = buildapi.StatusMessageCannotCreateBuildPod
 		return fmt.Errorf("failed to create build pod: %v", err)
 	}
-	common.SetBuildPodNameAnnotation(build, podSpec.Name)
 	glog.V(4).Infof("Created pod for build: %#v", podSpec)
+	bc.Recorder.Eventf(build, kapi.EventTypeNormal, buildapi.BuildStartedEventReason, fmt.Sprintf(buildapi.BuildStartedEventMessage, build.Namespace, build.Name))
+	common.SetBuildPodNameAnnotation(build, podSpec.Name)
 
 	// Set the build phase, which will be persisted.
 	build.Status.Phase = buildapi.BuildPhasePending

pkg/build/controller/image_change_controller_test.go

@@ -13,6 +13,7 @@ import (
 	buildapi "github.com/openshift/origin/pkg/build/api"
 	buildtest "github.com/openshift/origin/pkg/build/controller/test"
 	buildgenerator "github.com/openshift/origin/pkg/build/generator"
+	mocks "github.com/openshift/origin/pkg/build/generator/test"
 	"github.com/openshift/origin/pkg/cmd/server/bootstrappolicy"
 	imageapi "github.com/openshift/origin/pkg/image/api"
 )
@@ -386,7 +387,11 @@ func mockBuildConfigInstantiator(buildcfg *buildapi.BuildConfig, imageStream *im
 	}
 	instantiator := &buildConfigInstantiator{}
 	instantiator.buildConfigUpdater = &mockBuildConfigUpdater{}
+	recorder := &mocks.MockEventRecorder{}
+	buildGetter := &mocks.MockBuildGetter{}
 	generator := buildgenerator.BuildGenerator{
+		Builds:          buildGetter,
+		Recorder:        recorder,
 		Secrets:         fake.NewSimpleClientset().Core(),
 		ServiceAccounts: fake.NewSimpleClientset(&builderAccount).Core(),
 		Client: buildgenerator.Client{

pkg/build/generator/generator.go

@@ -13,10 +13,12 @@ import (
 	"k8s.io/kubernetes/pkg/api/errors"
 	"k8s.io/kubernetes/pkg/api/unversioned"
 	kcoreclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion"
+	"k8s.io/kubernetes/pkg/client/record"
 	"k8s.io/kubernetes/pkg/credentialprovider"
 	kvalidation "k8s.io/kubernetes/pkg/util/validation"
 
 	buildapi "github.com/openshift/origin/pkg/build/api"
+	buildclient "github.com/openshift/origin/pkg/build/client"
 	buildutil "github.com/openshift/origin/pkg/build/util"
 	"github.com/openshift/origin/pkg/cmd/admin/policy"
 	"github.com/openshift/origin/pkg/cmd/server/bootstrappolicy"
@@ -49,6 +51,8 @@ type BuildGenerator struct {
 	DefaultServiceAccountName string
 	ServiceAccounts           kcoreclient.ServiceAccountsGetter
 	Secrets                   kcoreclient.SecretsGetter
+	Recorder                  record.EventRecorder
+	Builds                    buildclient.BuildGetter
 }
 
 // GeneratorClient is the API client used by the generator
@@ -430,7 +434,12 @@ func (g *BuildGenerator) createBuild(ctx kapi.Context, build *buildapi.Build) (*
 	if err != nil {
 		return nil, err
 	}
-	return g.Client.GetBuild(ctx, build.Name)
+	b, err := g.Builds.Get(build.Namespace, build.Name)
+	//b, err := g.Client.GetBuild(ctx, build.Name)
+	if err == nil {
+		g.Recorder.Eventf(b, kapi.EventTypeNormal, buildapi.BuildCreatedEventReason, fmt.Sprintf(buildapi.BuildCreatedEventMessage, build.Namespace, build.Name))
+	}
+	return build, err
 }
 
 // generateBuildFromConfig generates a build definition based on the current imageid