Skip to content

Commit a7df486

Browse files
Merge pull request #18146 from gnufied/fix-resize-admission-config
Automatic merge from submit-queue. Add resize plugin to admission list Without this - it isn't possible to enable this plugin. Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1531513 Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1532149
2 parents 47a1900 + 3c3a358 commit a7df486

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

Diff for: pkg/cmd/server/origin/admission/chain_builder.go

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
admissionmetrics "k8s.io/apiserver/pkg/admission/metrics"
1414
"k8s.io/apiserver/pkg/admission/plugin/namespace/lifecycle"
1515
noderestriction "k8s.io/kubernetes/plugin/pkg/admission/noderestriction"
16+
expandpvcadmission "k8s.io/kubernetes/plugin/pkg/admission/persistentvolume/resize"
1617
saadmit "k8s.io/kubernetes/plugin/pkg/admission/serviceaccount"
1718
storageclassdefaultadmission "k8s.io/kubernetes/plugin/pkg/admission/storageclass/setdefault"
1819

@@ -65,6 +66,7 @@ var (
6566
noderestriction.PluginName,
6667
sccadmission.PluginName,
6768
storageclassdefaultadmission.PluginName,
69+
expandpvcadmission.PluginName,
6870
"AlwaysPullImages",
6971
"LimitPodHardAntiAffinityTopology",
7072
"SCCExecRestrictions",
@@ -112,6 +114,7 @@ var (
112114
noderestriction.PluginName,
113115
sccadmission.PluginName,
114116
storageclassdefaultadmission.PluginName,
117+
expandpvcadmission.PluginName,
115118
"AlwaysPullImages",
116119
"LimitPodHardAntiAffinityTopology",
117120
"SCCExecRestrictions",

Diff for: pkg/cmd/server/origin/admission/config_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
overrideapi "github.com/openshift/origin/pkg/quota/admission/clusterresourceoverride/api"
1414
sccadmission "github.com/openshift/origin/pkg/security/admission"
1515
serviceadmit "github.com/openshift/origin/pkg/service/admission"
16+
expandpvcadmission "k8s.io/kubernetes/plugin/pkg/admission/persistentvolume/resize"
1617
)
1718

1819
// TestAdmissionPluginChains makes sure that the admission plugin lists are coherent.
@@ -95,6 +96,7 @@ var usedKubeAdmissionPlugins = sets.NewString(
9596
"ExtendedResourceToleration",
9697
"PVCProtection",
9798
"NodeRestriction",
99+
expandpvcadmission.PluginName,
98100
)
99101

100102
// TestAdmissionPluginNames makes sure that openshift admission plugins are prefixed with `openshift.io/`.

Diff for: pkg/cmd/server/origin/admission/register.go

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
serviceadmit "github.com/openshift/origin/pkg/service/admission"
3131

3232
"k8s.io/kubernetes/plugin/pkg/admission/noderestriction"
33+
expandpvcadmission "k8s.io/kubernetes/plugin/pkg/admission/persistentvolume/resize"
3334
storageclassdefaultadmission "k8s.io/kubernetes/plugin/pkg/admission/storageclass/setdefault"
3435

3536
imagepolicyapi "github.com/openshift/origin/pkg/image/admission/imagepolicy/api"
@@ -121,6 +122,7 @@ var (
121122
"PodTolerationRestriction",
122123
"ExtendedResourceToleration",
123124
"PVCProtection",
125+
expandpvcadmission.PluginName,
124126
)
125127
)
126128

0 commit comments

Comments
 (0)