better warn users when the buildconfig is of type binary

also remove some dead code
also properly parse git urls so we recognize when the
buildconfig we created really is/isn't binary.

Author: bparees

pkg/generate/app/cmd/describe.go

@@ -171,11 +171,18 @@ func describeBuildPipelineWithImage(out io.Writer, ref app.ComponentReference, p
 				fmt.Fprintf(out, "      * The resulting image will be pushed to %s %q\n", to.Kind, to.Name)
 			}
 		}
-		if len(trackedImage) > 0 {
-			if noSource {
-				fmt.Fprintf(out, "      * Use 'start-build --from-dir=DIR' to trigger a new build\n")
-			} else {
+
+		if noSource {
+			// if we have no source, the user must always provide the source from the local dir(binary build)
+			fmt.Fprintf(out, "      * Use 'start-build --from-dir=DIR' to trigger a new build\n")
+			fmt.Fprintf(out, "      * WARNING: a binary build was created, you must specify --from-dir/--from-file/--from-repo when starting builds\n")
+		} else {
+			if len(trackedImage) > 0 {
+				// if we have a trackedImage/ICT and we have source, the build will be triggered automatically.
 				fmt.Fprintf(out, "      * Every time %q changes a new build will be triggered\n", trackedImage)
+			} else {
+				// if we have source (but not a tracked image), the user must manually trigger a build.
+				fmt.Fprintf(out, "      * Use 'start-build to trigger a new build\n")
 			}
 		}
 	}

pkg/generate/app/sourcelookup.go

@@ -269,7 +269,8 @@ func (r *SourceRepository) RemoteURL() (*url.URL, bool, error) {
 		if len(ref) > 0 {
 			remote = fmt.Sprintf("%s#%s", remote, ref)
 		}
-		if r.remoteURL, err = url.Parse(remote); err != nil {
+
+		if r.remoteURL, err = git.ParseRepository(remote); err != nil {
 			return nil, false, err
 		}
 	default: