Merge pull request #18505 from mrogers950/osin-log

Automatic merge from submit-queue (batch tested with PRs 18505, 18617, 18604).

Enable osin internal error logging

osin now has an interface for internal error logging that provides some additional context on failure.

Example output:
```
=== RUN   TestClientCredentialFlow
--- PASS: TestClientCredentialFlow (0.00s)
=== RUN   TestAuthorizeStartFlow
I0206 14:58:22.818652   22392 access.go:561] osin: error=unauthorized_client, internal_error=<nil> get_client=client check failed, client_id=test
--- FAIL: TestAuthorizeStartFlow (0.00s)
osinserver_test.go:95: unexpected error: The client is not authorized to request a token using this method.
osinserver_test.go:135: unexpected error: Get http://127.0.0.1:39369/assert?code=KWhLRoflbPdPCNYNP6T3MpqZn4mv0zxKLU6TRg6QEAc&state=: EOF
```
@openshift/sig-security

Author: openshift-merge-robot

glide.lock

@@ -134,7 +134,7 @@ import:
   version: 32a13797442ccb601b11761d74232773c1402d14
 # auth (for sally)
 - package: github.com/RangelReale/osin
-  version: 829186e6c125f77df6d6ae0162a9ba59fad91e2d
+  version: 2dc1b43167692cdc89446b99b98fa9de6bff020f
 # auth (for sally)
 - package: github.com/RangelReale/osincli
   version: fababb0555f21315d1a34af6615a16eaab44396b

glide.yaml

@@ -6,6 +6,7 @@ import (
 	"path"
 
 	"github.com/RangelReale/osin"
+	"github.com/golang/glog"
 
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 )
@@ -24,12 +25,23 @@ type Server struct {
 	errorHandler ErrorHandler
 }
 
+// Logger captures additional osin server errors
+type Logger struct {
+}
+
+func (l Logger) Printf(format string, v ...interface{}) {
+	if glog.V(2) {
+		glog.ErrorDepth(3, fmt.Sprintf("osin: "+format, v...))
+	}
+}
+
 func New(config *osin.ServerConfig, storage osin.Storage, authorize AuthorizeHandler, access AccessHandler, errorHandler ErrorHandler) *Server {
 	server := osin.NewServer(config, storage)
 
 	// Override tokengen to ensure we get valid length tokens
 	server.AuthorizeTokenGen = TokenGen{}
 	server.AccessTokenGen = TokenGen{}
+	server.Logger = Logger{}
 
 	return &Server{
 		config:       config,