Skip to content

Commit bc90009

Browse files
committed
fix tests
1 parent a680683 commit bc90009

File tree

1 file changed

+22
-23
lines changed

1 file changed

+22
-23
lines changed

pkg/build/util/util_test.go

+22-23
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,21 @@ import (
77

88
s2iapi "github.com/openshift/source-to-image/pkg/api"
99

10-
"k8s.io/api/core/v1"
11-
kapi "k8s.io/kubernetes/pkg/api"
10+
corev1 "k8s.io/api/core/v1"
1211

13-
buildapi "github.com/openshift/origin/pkg/build/apis/build"
12+
buildapiv1 "github.com/openshift/api/build/v1"
1413
)
1514

1615
func TestTrustedMergeEnvWithoutDuplicates(t *testing.T) {
17-
input := []v1.EnvVar{
16+
input := []corev1.EnvVar{
1817
// stripped by whitelist
1918
{Name: "foo", Value: "bar"},
2019
// stripped by whitelist
2120
{Name: "input", Value: "inputVal"},
2221
{Name: "GIT_SSL_NO_VERIFY", Value: "source"},
2322
{Name: "BUILD_LOGLEVEL", Value: "source"},
2423
}
25-
output := []v1.EnvVar{
24+
output := []corev1.EnvVar{
2625
{Name: "foo", Value: "test"},
2726
{Name: "GIT_SSL_NO_VERIFY", Value: "target"},
2827
}
@@ -52,15 +51,15 @@ func TestTrustedMergeEnvWithoutDuplicates(t *testing.T) {
5251
t.Errorf("Expected output env 'BUILD_LOGLEVEL' to have value 'loglevel', got %+v", output[1])
5352
}
5453

55-
input = []v1.EnvVar{
54+
input = []corev1.EnvVar{
5655
// stripped by whitelist
5756
{Name: "foo", Value: "bar"},
5857
// stripped by whitelist
5958
{Name: "input", Value: "inputVal"},
6059
{Name: "GIT_SSL_NO_VERIFY", Value: "source"},
6160
{Name: "BUILD_LOGLEVEL", Value: "source"},
6261
}
63-
output = []v1.EnvVar{
62+
output = []corev1.EnvVar{
6463
{Name: "foo", Value: "test"},
6564
{Name: "GIT_SSL_NO_VERIFY", Value: "target"},
6665
}
@@ -200,20 +199,20 @@ func checkEnvList(t *testing.T, envs s2iapi.EnvironmentList, orig bool) {
200199
func TestSafeForLoggingBuild(t *testing.T) {
201200
httpProxy := "http://user:[email protected]"
202201
httpsProxy := "https://user:[email protected]"
203-
proxyBuild := &buildapi.Build{
204-
Spec: buildapi.BuildSpec{
205-
CommonSpec: buildapi.CommonSpec{
206-
Source: buildapi.BuildSource{
207-
Git: &buildapi.GitBuildSource{
208-
ProxyConfig: buildapi.ProxyConfig{
202+
proxyBuild := &buildapiv1.Build{
203+
Spec: buildapiv1.BuildSpec{
204+
CommonSpec: buildapiv1.CommonSpec{
205+
Source: buildapiv1.BuildSource{
206+
Git: &buildapiv1.GitBuildSource{
207+
ProxyConfig: buildapiv1.ProxyConfig{
209208
HTTPProxy: &httpProxy,
210209
HTTPSProxy: &httpsProxy,
211210
},
212211
},
213212
},
214-
Strategy: buildapi.BuildStrategy{
215-
SourceStrategy: &buildapi.SourceBuildStrategy{
216-
Env: []kapi.EnvVar{
213+
Strategy: buildapiv1.BuildStrategy{
214+
SourceStrategy: &buildapiv1.SourceBuildStrategy{
215+
Env: []corev1.EnvVar{
217216
{
218217
Name: "HTTP_PROXY",
219218
Value: "http://user:[email protected]",
@@ -228,8 +227,8 @@ func TestSafeForLoggingBuild(t *testing.T) {
228227
},
229228
},
230229
},
231-
DockerStrategy: &buildapi.DockerBuildStrategy{
232-
Env: []kapi.EnvVar{
230+
DockerStrategy: &buildapiv1.DockerBuildStrategy{
231+
Env: []corev1.EnvVar{
233232
{
234233
Name: "HTTP_PROXY",
235234
Value: "http://user:[email protected]",
@@ -244,8 +243,8 @@ func TestSafeForLoggingBuild(t *testing.T) {
244243
},
245244
},
246245
},
247-
CustomStrategy: &buildapi.CustomBuildStrategy{
248-
Env: []kapi.EnvVar{
246+
CustomStrategy: &buildapiv1.CustomBuildStrategy{
247+
Env: []corev1.EnvVar{
249248
{
250249
Name: "HTTP_PROXY",
251250
Value: "http://user:[email protected]",
@@ -260,8 +259,8 @@ func TestSafeForLoggingBuild(t *testing.T) {
260259
},
261260
},
262261
},
263-
JenkinsPipelineStrategy: &buildapi.JenkinsPipelineBuildStrategy{
264-
Env: []kapi.EnvVar{
262+
JenkinsPipelineStrategy: &buildapiv1.JenkinsPipelineBuildStrategy{
263+
Env: []corev1.EnvVar{
265264
{
266265
Name: "HTTP_PROXY",
267266
Value: "http://user:[email protected]",
@@ -294,7 +293,7 @@ func TestSafeForLoggingBuild(t *testing.T) {
294293
checkEnv(t, stripped.Spec.Strategy.JenkinsPipelineStrategy.Env)
295294
}
296295

297-
func checkEnv(t *testing.T, envs []kapi.EnvVar) {
296+
func checkEnv(t *testing.T, envs []corev1.EnvVar) {
298297
for _, env := range envs {
299298
if env.Name == "other_value" {
300299
if !credsRegex.MatchString(env.Value) {

0 commit comments

Comments
 (0)