Skip to content

Commit c242a8b

Browse files
committed
UPSTREAM: 34020: Allow empty annotation values
Annotations with empty values can be used, for example, in diagnostics logging. This patch removes the client-side check for empty values in an annotation key-value pair. **Before** ``` $ kubectl annotate pod zookeeper-1 node-selector="" --overwrite error: invalid annotation format: node-selector= ``` **After** ``` $ kubectl annotate pod zookeeper-1 node-selector="" --overwrite pod "zookeper-1" annotated ``` ``` $ kubectl get po/zookeeper-1 --template='{{.metadata.annotations}}' map[... node-selector: test-label:test] ```
1 parent 01c20d0 commit c242a8b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/label.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)