|
| 1 | +package machine_config |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "fmt" |
| 6 | + "io/ioutil" |
| 7 | + "path/filepath" |
| 8 | + "strings" |
| 9 | + "time" |
| 10 | + |
| 11 | + g "github.com/onsi/ginkgo/v2" |
| 12 | + o "github.com/onsi/gomega" |
| 13 | + |
| 14 | + mcfgv1alpha1 "github.com/openshift/api/machineconfiguration/v1alpha1" |
| 15 | + mcClient "github.com/openshift/client-go/machineconfiguration/clientset/versioned" |
| 16 | + exutil "github.com/openshift/origin/test/extended/util" |
| 17 | + corev1 "k8s.io/api/core/v1" |
| 18 | + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| 19 | + |
| 20 | + "k8s.io/apimachinery/pkg/util/wait" |
| 21 | + "sigs.k8s.io/yaml" |
| 22 | +) |
| 23 | + |
| 24 | +// This test is [Serial] because it modifies the cluster/machineconfigurations.operator.openshift.io object in each test. |
| 25 | +var _ = g.Describe("[sig-mco][OCPFeatureGate:PinnedImages][OCPFeatureGate:MachineConfigNode][Serial]", func() { |
| 26 | + defer g.GinkgoRecover() |
| 27 | + var ( |
| 28 | + MCOMachineConfigurationBaseDir = exutil.FixturePath("testdata", "machine_config", "machineconfigurations") |
| 29 | + pinnedImageSetFixture = filepath.Join(MCOMachineConfigurationBaseDir, "pis.yaml") |
| 30 | + customMCP = filepath.Join(MCOMachineConfigurationBaseDir, "customMCP.yaml") |
| 31 | + customMCPpinnedImageSetFixture = filepath.Join(MCOMachineConfigurationBaseDir, "customMCPpis.yaml") |
| 32 | + customGCMCPpinnedImageSetFixture = filepath.Join(MCOMachineConfigurationBaseDir, "customGCMCPpis.yaml") |
| 33 | + customGcKC = filepath.Join(MCOMachineConfigurationBaseDir, "gcKC.yaml") |
| 34 | + invalidPinnedImageSetFixture = filepath.Join(MCOMachineConfigurationBaseDir, "invalidPis.yaml") |
| 35 | + oc = exutil.NewCLIWithoutNamespace("machine-config") |
| 36 | + ) |
| 37 | + // Ensure each test pins a separate image, since we are not deleting them after each |
| 38 | + |
| 39 | + g.It("All Nodes in a custom Pool should have the PinnedImages even after Garbage Collection [apigroup:machineconfiguration.openshift.io]", func() { |
| 40 | + // Create custom MCP |
| 41 | + err := oc.Run("apply").Args("-f", customMCP).Execute() |
| 42 | + o.Expect(err).NotTo(o.HaveOccurred()) |
| 43 | + defer deleteMCP(oc, "custom") |
| 44 | + |
| 45 | + // Add node to pool |
| 46 | + nodes, err := oc.KubeClient().CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{}) |
| 47 | + o.Expect(err).NotTo(o.HaveOccurred(), "Get all nodes") |
| 48 | + err = oc.AsAdmin().Run("label").Args("node", nodes.Items[0].Name, "node-role.kubernetes.io/custom="+"").Execute() |
| 49 | + |
| 50 | + // Apply KC to Pool |
| 51 | + err = oc.Run("apply").Args("-f", customGcKC).Execute() |
| 52 | + o.Expect(err).NotTo(o.HaveOccurred()) |
| 53 | + defer deleteKC(oc, "custom-gc-config") |
| 54 | + |
| 55 | + SimplePISTest(oc, customGCMCPpinnedImageSetFixture, true) |
| 56 | + }) |
| 57 | + |
| 58 | + g.It("All Nodes in a Custom Pool should have the PinnedImages in PIS [apigroup:machineconfiguration.openshift.io]", func() { |
| 59 | + // Create custom MCP |
| 60 | + err := oc.Run("apply").Args("-f", customMCP).Execute() |
| 61 | + o.Expect(err).NotTo(o.HaveOccurred()) |
| 62 | + defer deleteMCP(oc, "custom") |
| 63 | + |
| 64 | + // Add node to pool |
| 65 | + nodes, err := oc.KubeClient().CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{}) |
| 66 | + o.Expect(err).NotTo(o.HaveOccurred(), "Get all nodes") |
| 67 | + err = oc.AsAdmin().Run("label").Args("node", nodes.Items[0].Name, "node-role.kubernetes.io/custom="+"").Execute() |
| 68 | + |
| 69 | + SimplePISTest(oc, customMCPpinnedImageSetFixture, true) |
| 70 | + }) |
| 71 | + |
| 72 | + g.It("All Nodes in a standard Pool should have the PinnedImages PIS [apigroup:machineconfiguration.openshift.io]", func() { |
| 73 | + SimplePISTest(oc, pinnedImageSetFixture, true) |
| 74 | + }) |
| 75 | + |
| 76 | + g.It("Invalid PIS leads to degraded MCN in a standard Pool [apigroup:machineconfiguration.openshift.io]", func() { |
| 77 | + SimplePISTest(oc, invalidPinnedImageSetFixture, false) |
| 78 | + }) |
| 79 | + |
| 80 | + g.It("Invalid PIS leads to degraded MCN in a custom Pool [apigroup:machineconfiguration.openshift.io]", func() { |
| 81 | + // Create custom MCP |
| 82 | + err := oc.Run("apply").Args("-f", customMCP).Execute() |
| 83 | + o.Expect(err).NotTo(o.HaveOccurred()) |
| 84 | + defer deleteMCP(oc, "custom") |
| 85 | + |
| 86 | + // Add node to pool |
| 87 | + nodes, err := oc.KubeClient().CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{}) |
| 88 | + o.Expect(err).NotTo(o.HaveOccurred(), "Get all nodes") |
| 89 | + err = oc.AsAdmin().Run("label").Args("node", nodes.Items[0].Name, "node-role.kubernetes.io/custom="+"").Execute() |
| 90 | + |
| 91 | + SimplePISTest(oc, invalidPinnedImageSetFixture, false) |
| 92 | + }) |
| 93 | + |
| 94 | +}) |
| 95 | + |
| 96 | +func SimplePISTest(oc *exutil.CLI, fixture string, success bool) { |
| 97 | + clientSet, err := mcClient.NewForConfig(oc.KubeFramework().ClientConfig()) |
| 98 | + o.Expect(err).NotTo(o.HaveOccurred()) |
| 99 | + |
| 100 | + pis, err := getPISFromFixture(fixture) |
| 101 | + o.Expect(err).NotTo(o.HaveOccurred()) |
| 102 | + |
| 103 | + err = oc.Run("apply").Args("-f", fixture).Execute() |
| 104 | + o.Expect(err).NotTo(o.HaveOccurred(), "Applied PIS") |
| 105 | + defer deletePIS(oc, pis.Name) |
| 106 | + |
| 107 | + waitTime := time.Minute * 20 |
| 108 | + ctx, cancel := context.WithTimeout(context.Background(), waitTime) |
| 109 | + defer cancel() |
| 110 | + |
| 111 | + waitForPISStatusX(ctx, oc, clientSet, pis.Name, success) |
| 112 | +} |
| 113 | + |
| 114 | +func detectXCondition(oc *exutil.CLI, node corev1.Node, mcn *mcfgv1alpha1.MachineConfigNode, appliedPIS *mcfgv1alpha1.PinnedImageSet, detectingSuccess bool) (bool, bool, error) { |
| 115 | + if detectingSuccess { |
| 116 | + for _, cond := range mcn.Status.Conditions { |
| 117 | + if mcfgv1alpha1.StateProgress(cond.Type) == mcfgv1alpha1.MachineConfigNodePinnedImageSetsDegraded && cond.Status == "True" { |
| 118 | + return false, true, fmt.Errorf("PIS degraded for MCN %s with reason: %s and message: %s", mcn.Name, cond.Reason, cond.Message) |
| 119 | + } |
| 120 | + |
| 121 | + if mcfgv1alpha1.StateProgress(cond.Type) == mcfgv1alpha1.MachineConfigNodePinnedImageSetsProgressing && cond.Status == "True" { |
| 122 | + return false, false, nil |
| 123 | + } |
| 124 | + } |
| 125 | + for _, img := range appliedPIS.Spec.PinnedImages { |
| 126 | + crictlStatus, err := exutil.DebugNodeRetryWithOptionsAndChroot(oc, node.Name, "openshift-machine-config-operator", "crictl", "inspecti", img.Name) |
| 127 | + if err != nil { |
| 128 | + return false, false, fmt.Errorf("failed to execute `crictl inspecti %s` on node %s: %w", img.Name, node.Name, err) |
| 129 | + } |
| 130 | + if !strings.Contains(crictlStatus, "imageSpec") { |
| 131 | + return false, true, fmt.Errorf("Image %s not present on node %s: %w", img.Name, node.Name, err) |
| 132 | + } |
| 133 | + } |
| 134 | + return true, false, nil |
| 135 | + } else { |
| 136 | + for _, cond := range mcn.Status.Conditions { |
| 137 | + if mcfgv1alpha1.StateProgress(cond.Type) == mcfgv1alpha1.MachineConfigNodePinnedImageSetsDegraded && cond.Status == "True" { |
| 138 | + continue |
| 139 | + } |
| 140 | + if mcfgv1alpha1.StateProgress(cond.Type) == mcfgv1alpha1.MachineConfigNodePinnedImageSetsProgressing && cond.Status == "True" { |
| 141 | + return false, false, nil |
| 142 | + } |
| 143 | + } |
| 144 | + return true, false, nil |
| 145 | + } |
| 146 | +} |
| 147 | + |
| 148 | +func waitForPISStatusX(ctx context.Context, oc *exutil.CLI, clientSet *mcClient.Clientset, pisName string, success bool) error { |
| 149 | + return wait.PollUntilContextCancel(ctx, time.Second, true, func(ctx context.Context) (done bool, err error) { |
| 150 | + // Wait for PIS object to get created |
| 151 | + appliedPIS, err := clientSet.MachineconfigurationV1alpha1().PinnedImageSets().Get(context.TODO(), pisName, metav1.GetOptions{}) |
| 152 | + if err != nil { |
| 153 | + return false, fmt.Errorf("PIS Object not created yet: %w", err) |
| 154 | + } |
| 155 | + |
| 156 | + pool, err := clientSet.MachineconfigurationV1().MachineConfigPools().Get(ctx, appliedPIS.Labels["machineconfiguration.openshift.io/role"], metav1.GetOptions{}) |
| 157 | + if err != nil { |
| 158 | + return true, fmt.Errorf("failed to get MCP mentioned in PIS: %w", err) |
| 159 | + } |
| 160 | + |
| 161 | + nodes, err := getNodesForPool(ctx, oc, pool) |
| 162 | + doneNodes := 0 |
| 163 | + for _, node := range nodes.Items { |
| 164 | + mcn, err := clientSet.MachineconfigurationV1alpha1().MachineConfigNodes().Get(ctx, node.Name, metav1.GetOptions{}) |
| 165 | + if err != nil { |
| 166 | + return true, fmt.Errorf("failed to get mcn: %w", err) |
| 167 | + } |
| 168 | + toContinue, isDone, err := detectXCondition(oc, node, mcn, appliedPIS, success) |
| 169 | + if !toContinue { |
| 170 | + return isDone, err |
| 171 | + } |
| 172 | + doneNodes += 1 |
| 173 | + } |
| 174 | + if doneNodes == len(nodes.Items) { |
| 175 | + return true, nil |
| 176 | + } |
| 177 | + |
| 178 | + return false, nil |
| 179 | + }) |
| 180 | +} |
| 181 | + |
| 182 | +func deleteKC(oc *exutil.CLI, name string) error { |
| 183 | + err := oc.Run("delete").Args("kubeletconfig", name).Execute() |
| 184 | + return err |
| 185 | +} |
| 186 | + |
| 187 | +func deleteMCP(oc *exutil.CLI, name string) error { |
| 188 | + err := oc.Run("delete").Args("mcp", name).Execute() |
| 189 | + return err |
| 190 | +} |
| 191 | + |
| 192 | +func deletePIS(oc *exutil.CLI, name string) error { |
| 193 | + err := oc.Run("delete").Args("pinnedimageset", name).Execute() |
| 194 | + return err |
| 195 | +} |
| 196 | + |
| 197 | +func getPISFromFixture(path string) (*mcfgv1alpha1.PinnedImageSet, error) { |
| 198 | + data, err := ioutil.ReadFile(path) |
| 199 | + if err != nil { |
| 200 | + return nil, err |
| 201 | + } |
| 202 | + |
| 203 | + ob := new(mcfgv1alpha1.PinnedImageSet) |
| 204 | + err = yaml.Unmarshal(data, ob) |
| 205 | + if err != nil { |
| 206 | + return nil, err |
| 207 | + } |
| 208 | + |
| 209 | + return ob, err |
| 210 | +} |
0 commit comments