Changed to a switch statment on tls.Termination in validator

Author: JacobTanenbaum

pkg/route/api/validation/validation.go

@@ -272,14 +272,17 @@ func validateInsecureEdgeTerminationPolicy(tls *routeapi.TLSConfig, fldPath *fie
 		routeapi.InsecureEdgeTerminationPolicyRedirect: {},
 	}
 
-	if routeapi.TLSTerminationEdge == tls.Termination || routeapi.TLSTerminationReencrypt == tls.Termination {
+	switch tls.Termination {
+	case routeapi.TLSTerminationReencrypt:
+		fallthrough
+	case routeapi.TLSTerminationEdge:
 		if _, ok := allowedValues[tls.InsecureEdgeTerminationPolicy]; !ok {
 			msg := fmt.Sprintf("invalid value for InsecureEdgeTerminationPolicy option, acceptable values are %s, %s, %s, or empty", routeapi.InsecureEdgeTerminationPolicyNone, routeapi.InsecureEdgeTerminationPolicyAllow, routeapi.InsecureEdgeTerminationPolicyRedirect)
 			return field.Invalid(fldPath, tls.InsecureEdgeTerminationPolicy, msg)
 		}
-	} else if routeapi.TLSTerminationPassthrough == tls.Termination {
+	case routeapi.TLSTerminationPassthrough:
 		if routeapi.InsecureEdgeTerminationPolicyNone != tls.InsecureEdgeTerminationPolicy && routeapi.InsecureEdgeTerminationPolicyRedirect != tls.InsecureEdgeTerminationPolicy {
-			msg := fmt.Sprintf("invalid value for InsecureEdgeTerminationPolicy option acceptable values are %s, %s, or empty", routeapi.InsecureEdgeTerminationPolicyNone, routeapi.InsecureEdgeTerminationPolicyRedirect)
+			msg := fmt.Sprintf("invalid value for InsecureEdgeTerminationPolicy option, acceptable values are %s, %s, or empty", routeapi.InsecureEdgeTerminationPolicyNone, routeapi.InsecureEdgeTerminationPolicyRedirect)
 			return field.Invalid(fldPath, tls.InsecureEdgeTerminationPolicy, msg)
 		}
 	}