Merge pull request #20563 from gabemontero/ext-tst-gcp-prow-diag

info/diag for direct ext test invocation on gcp/prow

Author: openshift-merge-robot

Diff for: test/extended/builds/pipeline.go

@@ -3,6 +3,7 @@ package builds
 import (
 	"errors"
 	"fmt"
+	"io/ioutil"
 	"net/http"
 	"net/url"
 	"os"
@@ -810,6 +811,16 @@ var _ = g.Describe("[Feature:Builds][Slow] openshift pipeline build", func() {
 				g.By(fmt.Sprintf("creating git repo %v", envVarsPipelineGitRepoBuildConfig))
 				repo, err := exutil.NewGitRepo(envVarsPipelineGitRepoBuildConfig)
 				defer repo.Remove()
+				if err != nil {
+					files, dbgerr := ioutil.ReadDir("/tmp")
+					if dbgerr != nil {
+						e2e.Logf("problem diagnosing /tmp: %v", dbgerr)
+					} else {
+						for _, file := range files {
+							e2e.Logf("found file %s under temp isdir %q mode %s", file.Name(), file.IsDir(), file.Mode().String())
+						}
+					}
+				}
 				o.Expect(err).NotTo(o.HaveOccurred())
 				jf := `node() {\necho "FOO1 is ${env.FOO1}"\necho"FOO2is${env.FOO2}"\necho"FOO3is${env.FOO3}"\necho"FOO4is${env.FOO4}"}`
 				err = repo.AddAndCommit("Jenkinsfile", jf)

Diff for: test/extended/util/cli.go

@@ -85,21 +85,27 @@ func NewCLI(project, adminConfigPath string) *CLI {
 
 	g.BeforeEach(client.SetupProject)
 
-	ProwGCPSetup(client)
-
 	return client
 }
 
 // ProwGCPSetup makes sure certain required env vars are available in the case
 // that extended tests are invoked directly via calls to ginkgo/extended.test
 func ProwGCPSetup(oc *CLI) {
 	tn := os.Getenv("OS_TEST_NAMESPACE")
+	ad := os.Getenv("ARTIFACT_DIR")
+	btd := os.Getenv("BASETMPDIR")
+	e2e.Logf("OS_TEST_NAMESPACE env setting %s, ARTIFACT_DIR env setting %s BASETMPDIR %s", tn, ad, btd)
 	if len(strings.TrimSpace(tn)) == 0 {
 		os.Setenv("OS_TEST_NAMESPACE", oc.Namespace())
+		e2e.Logf("OS_TEST_NAMESPACE env setting now %s", os.Getenv("OS_TEST_NAMESPACE"))
 	}
-	ad := os.Getenv("ARTIFACT_DIR")
 	if len(strings.TrimSpace(ad)) == 0 {
 		os.Setenv("ARTIFACT_DIR", "/tmp/artifacts")
+		e2e.Logf("ARTIFACT_DIR env setting now %s", os.Getenv("ARTIFACT_DIR"))
+	}
+	if len(strings.TrimSpace(btd)) == 0 {
+		os.Setenv("BASETMPDIR", "/tmp/shared")
+		e2e.Logf("BASETMPDIR setting is now %s", os.Getenv("BASETMPDIR"))
 	}
 
 }
@@ -176,6 +182,7 @@ func (c *CLI) SetupProject() {
 	newNamespace := names.SimpleNameGenerator.GenerateName(fmt.Sprintf("e2e-test-%s-", c.kubeFramework.BaseName))
 	c.SetNamespace(newNamespace).ChangeUser(fmt.Sprintf("%s-user", newNamespace))
 	e2e.Logf("The user is now %q", c.Username())
+	ProwGCPSetup(c)
 
 	e2e.Logf("Creating project %q", newNamespace)
 	_, err := c.ProjectClient().Project().ProjectRequests().Create(&projectapi.ProjectRequest{

Diff for: test/extended/util/jenkins/ref.go

@@ -264,6 +264,17 @@ func (j *JenkinsRef) ProcessJenkinsJobUsingVars(filename, namespace string, vars
 	o.ExpectWithOffset(1, err).NotTo(o.HaveOccurred())
 
 	newfile, err := exutil.CreateTempFile(string(data))
+	e2e.Logf("new temp file %s err %v", newfile, err)
+	if err != nil {
+		files, dbgerr := ioutil.ReadDir("/tmp")
+		if dbgerr != nil {
+			e2e.Logf("problem diagnosing /tmp: %v", dbgerr)
+		} else {
+			for _, file := range files {
+				e2e.Logf("found file %s under temp isdir %q mode %s", file.Name(), file.IsDir(), file.Mode().String())
+			}
+		}
+	}
 	o.ExpectWithOffset(1, err).NotTo(o.HaveOccurred())
 	return newfile