Stop depending on $BASETMPDIR for os::cmd tempfiles

The resolution of the temporary file assignment in the `os::cmd` code
now happens before `$BASETMPDIR` is set, so we should not rely on it.

Signed-off-by: Steve Kuznetsov <[email protected]>

Author: stevekuznetsov

hack/lib/cmd.sh

@@ -157,8 +157,7 @@ readonly -f os::cmd::try_until_text
 
 # In order to harvest stderr and stdout at the same time into different buckets, we need to stick them into files
 # in an intermediate step
-BASETMPDIR="${TMPDIR:-"/tmp"}/openshift"
-os_cmd_internal_tmpdir="${BASETMPDIR}/test-cmd"
+os_cmd_internal_tmpdir="${TMPDIR:-"/tmp"}/openshift"
 os_cmd_internal_tmpout="${os_cmd_internal_tmpdir}/tmp_stdout.log"
 os_cmd_internal_tmperr="${os_cmd_internal_tmpdir}/tmp_stderr.log"