Skip to content

Commit e0c904f

Browse files
author
OpenShift Bot
authoredJul 7, 2017
Merge pull request #14838 from php-coder/backport_sa_and_secrets_storage_config
Merged by openshift-bot
2 parents 06c65e8 + ab93dcd commit e0c904f

File tree

3 files changed

+34
-8
lines changed

3 files changed

+34
-8
lines changed
 

Diff for: ‎pkg/cmd/server/origin/master_config.go

+15-3
Original file line numberDiff line numberDiff line change
@@ -900,14 +900,26 @@ func newServiceAccountTokenGetter(options configapi.MasterConfig) (serviceaccoun
900900
return nil, err
901901
}
902902

903-
storageConfig, err := kubeStorageFactory.NewConfig(kapi.Resource("serviceaccounts"))
903+
storageConfigServiceAccounts, err := kubeStorageFactory.NewConfig(kapi.Resource("serviceaccounts"))
904904
if err != nil {
905905
return nil, err
906906
}
907+
storageConfigSecrets, err := kubeStorageFactory.NewConfig(kapi.Resource("secrets"))
908+
if err != nil {
909+
return nil, err
910+
}
911+
907912
// TODO: by doing this we will not be able to authenticate while a master quorum is not present - reimplement
908913
// as two storages called in succession (non quorum and then quorum).
909-
storageConfig.Quorum = true
910-
return sacontroller.NewGetterFromStorageInterface(storageConfig, kubeStorageFactory.ResourcePrefix(kapi.Resource("serviceaccounts")), kubeStorageFactory.ResourcePrefix(kapi.Resource("secrets"))), nil
914+
storageConfigServiceAccounts.Quorum = true
915+
storageConfigSecrets.Quorum = true
916+
917+
return sacontroller.NewGetterFromStorageInterface(
918+
storageConfigServiceAccounts,
919+
kubeStorageFactory.ResourcePrefix(kapi.Resource("serviceaccounts")),
920+
storageConfigSecrets,
921+
kubeStorageFactory.ResourcePrefix(kapi.Resource("secrets")),
922+
), nil
911923
}
912924

913925
func newAuthenticator(config configapi.MasterConfig, restOptionsGetter restoptions.Getter, tokenGetter serviceaccount.ServiceAccountTokenGetter, apiClientCAs *x509.CertPool, groupMapper identitymapper.UserToGroupMapper) (authenticator.Request, error) {

Diff for: ‎vendor/k8s.io/kubernetes/cmd/kube-apiserver/app/server.go

+11-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎vendor/k8s.io/kubernetes/pkg/controller/serviceaccount/tokengetter.go

+8-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.