Skip to content

Commit ea49279

Browse files
coreydaleydeads2k
authored andcommitted
Updating docker --build-arg test due to docker code change
Docker changed the error for a non-existent --build-arg to a warning and changed the text of the message slightly, breaking one of our tests. Docker change: moby/moby@f150f42 Fixes: #16197
1 parent d452cf2 commit ea49279

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/extended/builds/start.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -308,14 +308,14 @@ var _ = g.Describe("[builds][Slow] starting a build using CLI", func() {
308308
g.By("verifying the build output contains the changes.")
309309
o.Expect(buildLog).To(o.ContainSubstring("bar"))
310310
})
311-
g.It("Should fail on non-existent build-arg", func() {
311+
g.It("Should complete with a warning on non-existent build-arg", func() {
312312
g.By("starting the build with --build-arg flag")
313313
br, _ := exutil.StartBuildAndWait(oc, "sample-build-docker-args", "--build-arg=bar=foo")
314-
br.AssertFailure()
314+
br.AssertSuccess()
315315
buildLog, err := br.Logs()
316316
o.Expect(err).NotTo(o.HaveOccurred())
317-
g.By("verifying the build failed due to Docker.")
318-
o.Expect(buildLog).To(o.ContainSubstring("One or more build-args [bar] were not consumed, failing build"))
317+
g.By("verifying the build completed with a warning.")
318+
o.Expect(buildLog).To(o.ContainSubstring("One or more build-args [bar] were not consumed"))
319319
})
320320
})
321321

0 commit comments

Comments
 (0)