fix the status and reason assignment

Author: Victor

Diff for: pkg/build/registry/build/strategy.go

@@ -110,27 +110,27 @@ type detailsStrategy struct {
 }
 
 // Prepares a build for update by only allowing an update to build details.
-// build details currently consists of: Spec.Revision, Status.Reason, and
+// Build details currently consists of: Spec.Revision, Status.Reason, and
 // Status.Message, all of which are updated from within the build pod
 func (detailsStrategy) PrepareForUpdate(obj, old runtime.Object) {
 	newBuild := obj.(*api.Build)
 	oldBuild := old.(*api.Build)
 	revision := newBuild.Spec.Revision
-	oldReason := oldBuild.Status.Reason
-	oldMessage := oldBuild.Status.Message
+	message := newBuild.Status.Message
+	reason := newBuild.Status.Reason
 	*newBuild = *oldBuild
 	newBuild.Spec.Revision = revision
-	newBuild.Status.Reason = oldReason
-	newBuild.Status.Message = oldMessage
+	newBuild.Status.Reason = reason
+	newBuild.Status.Message = message
 }
 
 // Validates that an update is valid by ensuring that no Revision exists and that it's not getting updated to blank
 func (detailsStrategy) ValidateUpdate(ctx kapi.Context, obj, old runtime.Object) field.ErrorList {
 	newBuild := obj.(*api.Build)
 	oldBuild := old.(*api.Build)
-	errors := field.ErrorList{}
 	oldRevision := oldBuild.Spec.Revision
 	newRevision := newBuild.Spec.Revision
+	errors := field.ErrorList{}
 
 	if newRevision == nil {
 		errors = append(errors, field.Invalid(field.NewPath("spec", "revision"), nil, "cannot set an empty revision in build spec"))