Skip to content

Commit f6d4a1b

Browse files
Merge pull request #16260 from simo5/dropbootpb
Automatic merge from submit-queue (batch tested with PRs 15945, 16252, 16260) Remove policy and policybinding from bootstrap policy Fixes #15820
2 parents e0016f6 + 574f530 commit f6d4a1b

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

pkg/cmd/server/bootstrappolicy/policy.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,7 @@ func GetOpenshiftBootstrapClusterRoles() []rbac.ClusterRole {
185185

186186
rbac.NewRule(read...).Groups(certificatesGroup).Resources("certificatesigningrequests", "certificatesigningrequests/approval", "certificatesigningrequests/status").RuleOrDie(),
187187

188-
rbac.NewRule(read...).Groups(authzGroup, legacyAuthzGroup).Resources("clusterpolicies", "clusterpolicybindings", "clusterroles", "clusterrolebindings",
189-
"policies", "policybindings", "roles", "rolebindings", "rolebindingrestrictions").RuleOrDie(),
188+
rbac.NewRule(read...).Groups(authzGroup, legacyAuthzGroup).Resources("clusterroles", "clusterrolebindings", "roles", "rolebindings", "rolebindingrestrictions").RuleOrDie(),
190189

191190
rbac.NewRule(read...).Groups(buildGroup, legacyBuildGroup).Resources("builds", "builds/details", "buildconfigs", "buildconfigs/webhooks", "builds/log").RuleOrDie(),
192191

@@ -316,7 +315,7 @@ func GetOpenshiftBootstrapClusterRoles() []rbac.ClusterRole {
316315
rbac.NewRule("create").Groups(securityGroup, legacySecurityGroup).Resources("podsecuritypolicysubjectreviews", "podsecuritypolicyselfsubjectreviews", "podsecuritypolicyreviews").RuleOrDie(),
317316
rbac.NewRule("create").Groups(kAuthzGroup).Resources("localsubjectaccessreviews").RuleOrDie(),
318317

319-
rbac.NewRule(read...).Groups(authzGroup, legacyAuthzGroup).Resources("policies", "policybindings", "rolebindingrestrictions").RuleOrDie(),
318+
rbac.NewRule(read...).Groups(authzGroup, legacyAuthzGroup).Resources("rolebindingrestrictions").RuleOrDie(),
320319

321320
rbac.NewRule(readWrite...).Groups(buildGroup, legacyBuildGroup).Resources("builds", "buildconfigs", "buildconfigs/webhooks").RuleOrDie(),
322321
rbac.NewRule(read...).Groups(buildGroup, legacyBuildGroup).Resources("builds/log").RuleOrDie(),
@@ -801,7 +800,6 @@ func GetOpenshiftBootstrapClusterRoles() []rbac.ClusterRole {
801800
rbac.NewRule(readWrite...).Groups(authzGroup, legacyAuthzGroup).Resources("rolebindings", "roles").RuleOrDie(),
802801
rbac.NewRule("create").Groups(authzGroup, legacyAuthzGroup).Resources("localresourceaccessreviews", "localsubjectaccessreviews", "subjectrulesreviews").RuleOrDie(),
803802
rbac.NewRule("create").Groups(kAuthzGroup).Resources("localsubjectaccessreviews").RuleOrDie(),
804-
rbac.NewRule(read...).Groups(authzGroup, legacyAuthzGroup).Resources("policies", "policybindings").RuleOrDie(),
805803

806804
rbac.NewRule("get").Groups(kapiGroup).Resources("namespaces").RuleOrDie(),
807805
rbac.NewRule("get", "delete").Groups(projectGroup, legacyProjectGroup).Resources("projects").RuleOrDie(),

test/testdata/bootstrappolicy/bootstrap_cluster_roles.yaml

-16
Original file line numberDiff line numberDiff line change
@@ -235,12 +235,8 @@ items:
235235
- ""
236236
- authorization.openshift.io
237237
resources:
238-
- clusterpolicies
239-
- clusterpolicybindings
240238
- clusterrolebindings
241239
- clusterroles
242-
- policies
243-
- policybindings
244240
- rolebindingrestrictions
245241
- rolebindings
246242
- roles
@@ -776,8 +772,6 @@ items:
776772
- ""
777773
- authorization.openshift.io
778774
resources:
779-
- policies
780-
- policybindings
781775
- rolebindingrestrictions
782776
verbs:
783777
- get
@@ -2504,16 +2498,6 @@ items:
25042498
- localsubjectaccessreviews
25052499
verbs:
25062500
- create
2507-
- apiGroups:
2508-
- ""
2509-
- authorization.openshift.io
2510-
resources:
2511-
- policies
2512-
- policybindings
2513-
verbs:
2514-
- get
2515-
- list
2516-
- watch
25172501
- apiGroups:
25182502
- ""
25192503
resources:

0 commit comments

Comments
 (0)