make template service broker forbidden error message friendlier

Jim Minter · Jim Minter · commit fc4b2c65c27e · 2017-06-09T10:58:39.000+01:00
diff --git a/pkg/template/registry/templateinstance/strategy.go b/pkg/template/registry/templateinstance/strategy.go
@@ -136,7 +136,7 @@ func (s *templateInstanceStrategy) validateImpersonation(templateInstance *templ
 			Group:     templateapi.GroupName,
 			Resource:  "templateinstances",
 		}); err != nil {
-			return field.ErrorList{field.Forbidden(field.NewPath("spec.requester.username"), fmt.Sprintf("impersonation forbidden: %v", err))}
+			return field.ErrorList{field.Forbidden(field.NewPath("spec.requester.username"), "you do not have permission to set username")}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ func (s templateInstanceStrategy) validateImpersonation(templateInstance templ`
`136`	`136`	`Group: templateapi.GroupName,`
`137`	`137`	`Resource: "templateinstances",`
`138`	`138`	`}); err != nil {`
`139`		`- return field.ErrorList{field.Forbidden(field.NewPath("spec.requester.username"), fmt.Sprintf("impersonation forbidden: %v", err))}`
	`139`	`+ return field.ErrorList{field.Forbidden(field.NewPath("spec.requester.username"), "you do not have permission to set username")}`
`140`	`140`	`}`
`141`	`141`	`}`
`142`	`142`