Skip to content

Commit fe4f498

Browse files
Merge pull request #17039 from smarterclayton/prom
Automatic merge from submit-queue. Update prometheus to 2.0.0 GA Fixes a number of crash / data loss issues. /hold
2 parents 9c232e2 + b591821 commit fe4f498

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

examples/prometheus/prometheus.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ parameters:
1717
value: openshift/oauth-proxy:v1.0.0
1818
- description: The location of the prometheus image
1919
name: IMAGE_PROMETHEUS
20-
value: openshift/prometheus:v2.0.0-dev.3
20+
value: openshift/prometheus:v2.0.0
2121
- description: The location of the alertmanager image
2222
name: IMAGE_ALERTMANAGER
2323
value: openshift/prometheus-alertmanager:v0.9.1

pkg/oc/bootstrap/bindata.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/extended/prometheus/prometheus.go

+9-2
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,28 @@ var _ = g.Describe("[Feature:Prometheus][Conformance] Prometheus", func() {
5959
p := expfmt.TextParser{}
6060
metrics, err = p.TextToMetricFamilies(bytes.NewBufferString(results))
6161
o.Expect(err).NotTo(o.HaveOccurred())
62-
62+
// original field in 2.0.0-beta
6363
counts := findCountersWithLabels(metrics["tsdb_samples_appended_total"], labels{})
6464
if len(counts) != 0 && counts[0] > 0 {
6565
success = true
6666
break
6767
}
68+
// 2.0.0-rc.0
6869
counts = findCountersWithLabels(metrics["tsdb_head_samples_appended_total"], labels{})
6970
if len(counts) != 0 && counts[0] > 0 {
7071
success = true
7172
break
7273
}
74+
// 2.0.0-rc.2
75+
counts = findCountersWithLabels(metrics["prometheus_tsdb_head_samples_appended_total"], labels{})
76+
if len(counts) != 0 && counts[0] > 0 {
77+
success = true
78+
break
79+
}
7380
time.Sleep(time.Second)
7481
continue
7582
}
76-
o.Expect(success).To(o.BeTrue(), fmt.Sprintf("Did not find tsdb_samples_appended_total or tsdb_head_samples_appended_total in:\n%#v,", metrics))
83+
o.Expect(success).To(o.BeTrue(), fmt.Sprintf("Did not find tsdb_samples_appended_total, tsdb_head_samples_appended_total, or prometheus_tsdb_head_samples_appended_total in:\n%#v,", metrics))
7784

7885
g.By("verifying the oauth-proxy reports a 403 on the root URL")
7986
err := expectURLStatusCodeExec(ns, execPodName, fmt.Sprintf("https://%s:%d", host, statsPort), 403)

test/extended/testdata/bindata.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)