Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openshift/origin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9c00dd30b21cc8dc2a56004d0d2a713a9e03c81c
Choose a base ref
..
head repository: openshift/origin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bbd3320ed90a9697cc57c62b99ef5ba9cc1fcb65
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/integration/oauth_serviceaccount_client_events_test.go
2 changes: 1 addition & 1 deletion test/integration/oauth_serviceaccount_client_events_test.go
View file
Original file line number Diff line number Diff line change
@@ -87,7 +87,7 @@ func TestOAuthServiceAccountClientEvent(t *testing.T) {
annotationPrefix: saoauth.OAuthRedirectModelAnnotationReferencePrefix + "1",
annotation: `{"kind":"foo","apiVersion":"oauth.openshift.io/v1","metadata":{"creationTimestamp":null},"reference":{"group":"foo","kind":"Route","name":"route1"}}`,
expectedEventReason: "NoSAOAuthRedirectURIs",
expectedEventMsg: `[no kind "foo" is registered for version "oauth.openshift.io/v1", system:serviceaccount:` + projectName + ":" + saName + " has no redirectURIs; set serviceaccounts.openshift.io/oauth-redirecturi.<some-value>=<redirect> or create a dynamic URI using serviceaccounts.openshift.io/oauth-redirectreference.<some-value>=<reference>]",
expectedEventMsg: `[no kind "foo" is registered for version "oauth.openshift.io/v1" in scheme "github.com/openshift/origin/pkg/serviceaccounts/oauthclient/oauthclientregistry.go:54", system:serviceaccount:` + projectName + ":" + saName + " has no redirectURIs; set serviceaccounts.openshift.io/oauth-redirecturi.<some-value>=<redirect> or create a dynamic URI using serviceaccounts.openshift.io/oauth-redirectreference.<some-value>=<reference>]",
numEvents: 1,
expectBadRequest: true,
},