diff --git a/vendor/k8s.io/kubernetes/pkg/kubelet/remote/BUILD b/vendor/k8s.io/kubernetes/pkg/kubelet/remote/BUILD index cee27f87387d..7a1aab281588 100644 --- a/vendor/k8s.io/kubernetes/pkg/kubelet/remote/BUILD +++ b/vendor/k8s.io/kubernetes/pkg/kubelet/remote/BUILD @@ -53,5 +53,6 @@ go_test( "//pkg/kubelet/apis/cri/testing:go_default_library", "//pkg/kubelet/remote/fake:go_default_library", "//vendor/github.com/stretchr/testify/assert:go_default_library", + "//vendor/github.com/stretchr/testify/require:go_default_library", ], ) diff --git a/vendor/k8s.io/kubernetes/pkg/kubelet/remote/fake/fake_runtime.go b/vendor/k8s.io/kubernetes/pkg/kubelet/remote/fake/fake_runtime.go index 36d8dbfd8fe6..292e3c69f6fa 100644 --- a/vendor/k8s.io/kubernetes/pkg/kubelet/remote/fake/fake_runtime.go +++ b/vendor/k8s.io/kubernetes/pkg/kubelet/remote/fake/fake_runtime.go @@ -60,7 +60,8 @@ func (f *RemoteRuntime) Start(endpoint string) error { return fmt.Errorf("failed to listen on %q: %v", endpoint, err) } - return f.server.Serve(l) + go f.server.Serve(l) + return nil } // Stop stops the fake remote runtime. diff --git a/vendor/k8s.io/kubernetes/pkg/kubelet/remote/remote_runtime_test.go b/vendor/k8s.io/kubernetes/pkg/kubelet/remote/remote_runtime_test.go index db5b31b6bf64..076ca96f6a40 100644 --- a/vendor/k8s.io/kubernetes/pkg/kubelet/remote/remote_runtime_test.go +++ b/vendor/k8s.io/kubernetes/pkg/kubelet/remote/remote_runtime_test.go @@ -21,6 +21,7 @@ import ( "time" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" internalapi "k8s.io/kubernetes/pkg/kubelet/apis/cri" apitest "k8s.io/kubernetes/pkg/kubelet/apis/cri/testing" fakeremote "k8s.io/kubernetes/pkg/kubelet/remote/fake" @@ -35,17 +36,17 @@ const ( // Users should call fakeRuntime.Stop() to cleanup the server. func createAndStartFakeRemoteRuntime(t *testing.T) (*fakeremote.RemoteRuntime, string) { endpoint, err := fakeremote.GenerateEndpoint() - assert.NoError(t, err) + require.NoError(t, err) fakeRuntime := fakeremote.NewFakeRemoteRuntime() - go fakeRuntime.Start(endpoint) + fakeRuntime.Start(endpoint) return fakeRuntime, endpoint } func createRemoteRuntimeService(endpoint string, t *testing.T) internalapi.RuntimeService { runtimeService, err := NewRemoteRuntimeService(endpoint, defaultConnectionTimeout) - assert.NoError(t, err) + require.NoError(t, err) return runtimeService }