Skip to content

Commit 0a52c6d

Browse files
committed
Rename createExtensionMc to createMc
This method handles both extension and image based MC, hence rename the method Signed-off-by: Pradipta Banerjee <[email protected]>
1 parent 3b7db79 commit 0a52c6d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

controllers/openshift_controller.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,7 @@ func (r *KataConfigOpenShiftReconciler) processKataConfigInstallRequest() (ctrl.
10661066
r.Log.Info("SCNodeRole is: " + machinePool)
10671067
}
10681068

1069-
wasMcJustCreated, err := r.createExtensionMc(machinePool)
1069+
wasMcJustCreated, err := r.createMc(machinePool)
10701070
if err != nil {
10711071
return ctrl.Result{Requeue: true}, nil
10721072
}
@@ -1263,22 +1263,22 @@ func (r *KataConfigOpenShiftReconciler) processKataConfigInstallRequest() (ctrl.
12631263
// If the first return value is 'true' it means that the MC was just created
12641264
// by this call, 'false' means that it's already existed. As usual, the first
12651265
// return value is only valid if the second one is nil.
1266-
func (r *KataConfigOpenShiftReconciler) createExtensionMc(machinePool string) (bool, error) {
1266+
func (r *KataConfigOpenShiftReconciler) createMc(machinePool string) (bool, error) {
12671267

12681268
// In case we're returning an error we want to make it explicit that
12691269
// the first return value is "not care". Unfortunately golang seems
12701270
// to lack syntax for creating an expression with default bool value
12711271
// hence this work-around.
12721272
var dummy bool
12731273

1274-
/* Create Machine Config object to enable sandboxed containers RHCOS extension */
1274+
/* Create Machine Config object to install sandboxed containers */
12751275

12761276
if r.ExistingMc != nil {
12771277
r.Log.Info("Existing MachineConfig already exists")
12781278
return false, nil
12791279
}
12801280

1281-
r.Log.Info("creating RHCOS extension MachineConfig")
1281+
r.Log.Info("creating RHCOS MachineConfig")
12821282
mc, err := r.newMCForCR(machinePool)
12831283
if err != nil {
12841284
return dummy, err

0 commit comments

Comments
 (0)