Skip to content

Commit e4aed38

Browse files
Bug [2099580] - This fix will take care of deletion part of CR in java Operator. (#97)
* big fix for deletion Custom resource * updated testdata
1 parent 8192c45 commit e4aed38

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

Diff for: docs/tutorial.md

+3-8
Original file line numberDiff line numberDiff line change
@@ -456,18 +456,11 @@ Below your `labelsForMemcached(Memcached m)` block in the
456456

457457
```
458458
private Deployment createMemcachedDeployment(Memcached m) {
459-
return new DeploymentBuilder()
459+
Deployment deployment = new DeploymentBuilder()
460460
.withMetadata(
461461
new ObjectMetaBuilder()
462462
.withName(m.getMetadata().getName())
463463
.withNamespace(m.getMetadata().getNamespace())
464-
.withOwnerReferences(
465-
new OwnerReferenceBuilder()
466-
.withApiVersion("v1")
467-
.withKind("Memcached")
468-
.withName(m.getMetadata().getName())
469-
.withUid(m.getMetadata().getUid())
470-
.build())
471464
.build())
472465
.withSpec(
473466
new DeploymentSpecBuilder()
@@ -495,6 +488,8 @@ Below your `labelsForMemcached(Memcached m)` block in the
495488
.build())
496489
.build())
497490
.build();
491+
deployment.addOwnerReference(m);
492+
return deployment;
498493
}
499494
```
500495

Diff for: testdata/quarkus/memcached-quarkus-operator/src/main/java/com/example/MemcachedReconciler.java

+3-8
Original file line numberDiff line numberDiff line change
@@ -84,18 +84,11 @@ private Map<String, String> labelsForMemcached(Memcached m) {
8484
}
8585

8686
private Deployment createMemcachedDeployment(Memcached m) {
87-
return new DeploymentBuilder()
87+
Deployment deployment = new DeploymentBuilder()
8888
.withMetadata(
8989
new ObjectMetaBuilder()
9090
.withName(m.getMetadata().getName())
9191
.withNamespace(m.getMetadata().getNamespace())
92-
.withOwnerReferences(
93-
new OwnerReferenceBuilder()
94-
.withApiVersion("v1")
95-
.withKind("Memcached")
96-
.withName(m.getMetadata().getName())
97-
.withUid(m.getMetadata().getUid())
98-
.build())
9992
.build())
10093
.withSpec(
10194
new DeploymentSpecBuilder()
@@ -123,6 +116,8 @@ private Deployment createMemcachedDeployment(Memcached m) {
123116
.build())
124117
.build())
125118
.build();
119+
deployment.addOwnerReference(m);
120+
return deployment;
126121
}
127122

128123
}

0 commit comments

Comments
 (0)