Skip to content

Commit 0505718

Browse files
committed
naming improvement
1 parent 4c0a462 commit 0505718

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: operator-framework/src/main/java/com/github/containersolutions/operator/processing/EventScheduler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ void scheduleEventFromApi(CustomResourceEvent event) {
7777
if (eventStore.containsNotScheduledEvent(event.resourceUid())) {
7878
log.debug("Replacing not scheduled event with actual event." +
7979
" New event: {}", event);
80-
eventStore.addOrReplaceEventAsNotScheduled(event);
80+
eventStore.addOrReplaceEventAsNotScheduledAndUpdateLastGeneration(event);
8181
return;
8282
}
8383
if (generationAware && !eventStore.hasLargerGenerationThanLastStored(event)) {
@@ -88,7 +88,7 @@ void scheduleEventFromApi(CustomResourceEvent event) {
8888
if (eventStore.containsEventUnderProcessing(event.resourceUid())) {
8989
log.debug("Scheduling event for later processing since there is an event under processing for same kind." +
9090
" New event: {}", event);
91-
eventStore.addOrReplaceEventAsNotScheduled(event);
91+
eventStore.addOrReplaceEventAsNotScheduledAndUpdateLastGeneration(event);
9292
return;
9393
}
9494
scheduleEventForExecution(event);
@@ -108,7 +108,7 @@ private void scheduleEventForExecution(CustomResourceEvent event) {
108108
log.warn("Event max retry limit reached. Will be discarded. {}", event);
109109
return;
110110
}
111-
eventStore.addEventUnderProcessing(event);
111+
eventStore.addEventUnderProcessingAndUpdateLastGeneration(event);
112112
executor.schedule(new EventConsumer(event, eventDispatcher, this),
113113
nextBackOff.get(), TimeUnit.MILLISECONDS);
114114
log.trace("Scheduled task for event: {}", event);

Diff for: operator-framework/src/main/java/com/github/containersolutions/operator/processing/EventStore.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public CustomResourceEvent removeEventNotScheduled(String uid) {
1717
return eventsNotScheduled.remove(uid);
1818
}
1919

20-
public void addOrReplaceEventAsNotScheduled(CustomResourceEvent event) {
20+
public void addOrReplaceEventAsNotScheduledAndUpdateLastGeneration(CustomResourceEvent event) {
2121
eventsNotScheduled.put(event.resourceUid(), event);
2222
updateLastGeneration(event);
2323
}
@@ -26,7 +26,7 @@ public boolean containsEventUnderProcessing(String uuid) {
2626
return eventsUnderProcessing.containsKey(uuid);
2727
}
2828

29-
public void addEventUnderProcessing(CustomResourceEvent event) {
29+
public void addEventUnderProcessingAndUpdateLastGeneration(CustomResourceEvent event) {
3030
eventsUnderProcessing.put(event.resourceUid(), event);
3131
updateLastGeneration(event);
3232
}

0 commit comments

Comments
 (0)