improve: naming target resource selector method (#2546)

Author: csviri

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java

@@ -114,7 +114,7 @@ public Optional<R> getSecondaryResource(P primary, Context<P> context) {
     if (secondaryResources.isEmpty()) {
       return Optional.empty();
     } else {
-      return selectManagedSecondaryResource(secondaryResources, primary, context);
+      return selectTargetSecondaryResource(secondaryResources, primary, context);
     }
 
   }
@@ -132,7 +132,7 @@ public Optional<R> getSecondaryResource(P primary, Context<P> context) {
    * @throws IllegalStateException if more than one candidate is found, in which case some other
    *         mechanism might be necessary to distinguish between candidate secondary resources
    */
-  protected Optional<R> selectManagedSecondaryResource(Set<R> secondaryResources, P primary,
+  protected Optional<R> selectTargetSecondaryResource(Set<R> secondaryResources, P primary,
       Context<P> context) {
     R desired = desired(primary, context);
     var targetResources = secondaryResources.stream().filter(r -> r.equals(desired)).toList();

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

@@ -222,9 +222,9 @@ protected void addSecondaryToPrimaryMapperAnnotations(R desired, P primary, Stri
   }
 
   @Override
-  protected Optional<R> selectManagedSecondaryResource(Set<R> secondaryResources, P primary,
+  protected Optional<R> selectTargetSecondaryResource(Set<R> secondaryResources, P primary,
       Context<P> context) {
-    ResourceID managedResourceID = managedSecondaryResourceID(primary, context);
+    ResourceID managedResourceID = targetSecondaryResourceID(primary, context);
     return secondaryResources.stream()
         .filter(r -> r.getMetadata().getName().equals(managedResourceID.getName()) &&
             Objects.equals(r.getMetadata().getNamespace(),
@@ -240,7 +240,7 @@ protected Optional<R> selectManagedSecondaryResource(Set<R> secondaryResources,
    * @param context of current reconciliation
    * @return id of the target managed resource
    */
-  protected ResourceID managedSecondaryResourceID(P primary, Context<P> context) {
+  protected ResourceID targetSecondaryResourceID(P primary, Context<P> context) {
     return ResourceID.fromResource(desired(primary, context));
   }
 

Diff for: operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstate/ExternalWithStateDependentResource.java

@@ -40,7 +40,7 @@ public Set<ExternalResource> fetchResources(
   }
 
   @Override
-  protected Optional<ExternalResource> selectManagedSecondaryResource(
+  protected Optional<ExternalResource> selectTargetSecondaryResource(
       Set<ExternalResource> secondaryResources,
       ExternalStateCustomResource primary, Context<ExternalStateCustomResource> context) {
     var id = getResourceID(primary);

Diff for: operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipledrsametypenodiscriminator/MultipleManagedDependentNoDiscriminatorConfigMap1.java

@@ -8,6 +8,7 @@
 import io.javaoperatorsdk.operator.api.reconciler.Context;
 import io.javaoperatorsdk.operator.processing.dependent.kubernetes.CRUDKubernetesDependentResource;
 import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependent;
+import io.javaoperatorsdk.operator.processing.event.ResourceID;
 
 @KubernetesDependent
 public class MultipleManagedDependentNoDiscriminatorConfigMap1
@@ -20,6 +21,19 @@ public MultipleManagedDependentNoDiscriminatorConfigMap1() {
     super(ConfigMap.class);
   }
 
+  /*
+   * Showcases optimization to avoid computing the whole desired state by providing the ResourceID
+   * of the target resource. In this particular case this would not be necessary, since desired
+   * state creation is pretty lightweight. However, this might make sense in situation where the
+   * desired state is more costly
+   */
+  protected ResourceID targetSecondaryResourceID(
+      MultipleManagedDependentNoDiscriminatorCustomResource primary,
+      Context<MultipleManagedDependentNoDiscriminatorCustomResource> context) {
+    return new ResourceID(primary.getMetadata().getName() + NAME_SUFFIX,
+        primary.getMetadata().getNamespace());
+  }
+
   @Override
   protected ConfigMap desired(MultipleManagedDependentNoDiscriminatorCustomResource primary,
       Context<MultipleManagedDependentNoDiscriminatorCustomResource> context) {