fix: properly set default namespaces in controller case

Signed-off-by: Chris Laprun <[email protected]>

Author: metacosm

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/InformerConfig.java

@@ -25,20 +25,22 @@
 
   /**
    * Specified which namespaces the associated informer monitors for custom resources events. If no
-   * namespace is specified then the informer will monitor the namespaces configured for the
-   * associated controller (or all namespaces if the configuration is done for a controller).
+   * namespace is specified then which namespaces the informer will monitor will depend on the
+   * context in which the informer is configured:
+   * <ul>
+   * <li>all namespaces if configuring a controller informer</li>
+   * <li>the namespaces configured for the associated controller if configuring an event source</li>
+   * </ul>
    *
+   * You can set a list of namespaces or use the following constants:
    * <ul>
-   * You can set a list of namespaces or also constants:
    * <li>{@link Constants#WATCH_ALL_NAMESPACES}</li>
    * <li>{@link Constants#WATCH_CURRENT_NAMESPACE}</li>
    * <li>{@link Constants#SAME_AS_CONTROLLER}</li>
    * </ul>
    * 
    * @return the array of namespaces the associated informer monitors
    */
-  // todo: use unset value as semantics needs to be different depending on whether the configuration
-  // is used on a controller or an informer
   String[] namespaces() default {Constants.SAME_AS_CONTROLLER};
 
   /**

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/InformerConfigHolder.java

@@ -125,7 +125,10 @@ void updateInformerConfigBuilder(
   public class Builder {
 
     public InformerConfigHolder<R> buildForController() {
-      if (namespaces == null || namespaces.isEmpty()) {
+      // if the informer config uses the default "same as controller" value, reset the namespaces to
+      // the default set for controllers
+      if (namespaces == null || namespaces.isEmpty()
+          || InformerConfiguration.inheritsNamespacesFromController(namespaces)) {
         namespaces = Constants.DEFAULT_NAMESPACES_SET;
       }
       return InformerConfigHolder.this;