improve: generics for prepare event source (#2407)

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

caffeine-bounded-cache-support/src/test/java/io/javaoperatorsdk/operator/processing/event/source/cache/sample/AbstractTestReconciler.java

@@ -70,7 +70,7 @@ protected void createConfigMap(P resource, Context<P> context) {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, P>> prepareEventSources(
       EventSourceContext<P> context) {
 
     var boundedItemStore =

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/EventSourceUtils.java

@@ -10,16 +10,16 @@
 public class EventSourceUtils {
 
   @SuppressWarnings("unchecked")
-  public static <R extends HasMetadata> List<EventSource> dependentEventSources(
-      EventSourceContext<R> eventSourceContext, DependentResource... dependentResources) {
+  public static <P extends HasMetadata> List<EventSource<?, P>> dependentEventSources(
+      EventSourceContext<P> eventSourceContext, DependentResource... dependentResources) {
     return Arrays.stream(dependentResources)
         .flatMap(dr -> dr.eventSource(eventSourceContext).stream()).toList();
   }
 
   @SuppressWarnings("unchecked")
-  public static <K extends HasMetadata> List<EventSource> eventSourcesFromWorkflow(
-      EventSourceContext<K> context,
-      Workflow<K> workflow) {
+  public static <P extends HasMetadata> List<EventSource<?, P>> eventSourcesFromWorkflow(
+      EventSourceContext<P> context,
+      Workflow<P> workflow) {
     return workflow.getDependentResourcesWithoutActivationCondition().stream()
         .flatMap(dr -> dr.eventSource(context).stream()).toList();
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Reconciler.java

@@ -27,7 +27,7 @@ public interface Reconciler<P extends HasMetadata> {
    *        sources
    * @return a list of event sources
    */
-  default List<EventSource> prepareEventSources(EventSourceContext<P> context) {
+  default List<EventSource<?, P>> prepareEventSources(EventSourceContext<P> context) {
     return Collections.emptyList();
   }
 

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/bulkdependent/StandaloneBulkDependentReconciler.java

@@ -35,7 +35,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, BulkDependentTestCustomResource>> prepareEventSources(
       EventSourceContext<BulkDependentTestCustomResource> context) {
     return List.of(dependent.initEventSource(context));
   }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/changenamespace/ChangeNamespaceTestReconciler.java

@@ -20,7 +20,7 @@ public class ChangeNamespaceTestReconciler
       new ConcurrentHashMap<>();
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, ChangeNamespaceTestCustomResource>> prepareEventSources(
       EventSourceContext<ChangeNamespaceTestCustomResource> context) {
 
     InformerEventSource<ConfigMap, ChangeNamespaceTestCustomResource> configMapES =

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/clusterscopedresource/ClusterScopedCustomResourceReconciler.java

@@ -53,7 +53,7 @@ private ConfigMap desired(ClusterScopedCustomResource resource) {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, ClusterScopedCustomResource>> prepareEventSources(
       EventSourceContext<ClusterScopedCustomResource> context) {
     var ies = new InformerEventSource<>(
         InformerConfiguration.from(ConfigMap.class, ClusterScopedCustomResource.class)

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/complexdependent/ComplexDependentReconciler.java

@@ -51,7 +51,7 @@ public UpdateControl<ComplexDependentCustomResource> reconcile(
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, ComplexDependentCustomResource>> prepareEventSources(
       EventSourceContext<ComplexDependentCustomResource> context) {
     InformerEventSource<Service, ComplexDependentCustomResource> serviceEventSource =
         new InformerEventSource<>(

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java

@@ -90,7 +90,7 @@ private ConfigMap createConfigMap(CreateUpdateEventFilterTestCustomResource reso
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, CreateUpdateEventFilterTestCustomResource>> prepareEventSources(
       EventSourceContext<CreateUpdateEventFilterTestCustomResource> context) {
     InformerConfiguration<ConfigMap> informerConfiguration =
         InformerConfiguration.from(ConfigMap.class, CreateUpdateEventFilterTestCustomResource.class)

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/dependentreinitialization/DependentReInitializationReconciler.java

@@ -24,7 +24,7 @@ public UpdateControl<DependentReInitializationCustomResource> reconcile(
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, DependentReInitializationCustomResource>> prepareEventSources(
       EventSourceContext<DependentReInitializationCustomResource> context) {
     return EventSourceUtils.dependentEventSources(context,
         configMapDependentResource);

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/dependentssa/DependentSSAReconciler.java

@@ -47,7 +47,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, DependnetSSACustomResource>> prepareEventSources(
       EventSourceContext<DependnetSSACustomResource> context) {
     return EventSourceUtils.dependentEventSources(context,
         ssaConfigMapDependent);

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/externalstate/ExternalStateDependentReconciler.java

@@ -34,7 +34,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, ExternalStateCustomResource>> prepareEventSources(
       EventSourceContext<ExternalStateCustomResource> context) {
     var configMapEventSource = new InformerEventSource<>(
         InformerConfiguration.from(ConfigMap.class, ExternalStateCustomResource.class).build(),

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/externalstate/ExternalStateReconciler.java

@@ -107,7 +107,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, ExternalStateCustomResource>> prepareEventSources(
       EventSourceContext<ExternalStateCustomResource> context) {
 
     configMapEventSource = new InformerEventSource<>(

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/externalstate/externalstatebulkdependent/ExternalStateBulkDependentReconciler.java

@@ -33,7 +33,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, ExternalStateBulkDependentCustomResource>> prepareEventSources(
       EventSourceContext<ExternalStateBulkDependentCustomResource> context) {
     var configMapEventSource = new InformerEventSource<>(
         InformerConfiguration.from(ConfigMap.class, ExternalStateBulkDependentCustomResource.class)

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/filter/FilterTestReconciler.java

@@ -49,7 +49,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, FilterTestCustomResource>> prepareEventSources(
       EventSourceContext<FilterTestCustomResource> context) {
 
     InformerEventSource<ConfigMap, FilterTestCustomResource> configMapES =

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/generickubernetesresource/generickubernetesdependentstandalone/GenericKubernetesDependentStandaloneReconciler.java

@@ -30,7 +30,7 @@ public UpdateControl<GenericKubernetesDependentStandaloneCustomResource> reconci
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, GenericKubernetesDependentStandaloneCustomResource>> prepareEventSources(
       EventSourceContext<GenericKubernetesDependentStandaloneCustomResource> context) {
     return List.of(dependent.eventSource(context).orElseThrow());
   }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/generickubernetesresource/generickubernetesresourcehandling/GenericKubernetesResourceHandlingReconciler.java

@@ -65,7 +65,7 @@ GenericKubernetesResource desiredConfigMap(
 
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, GenericKubernetesResourceHandlingCustomResource>> prepareEventSources(
       EventSourceContext<GenericKubernetesResourceHandlingCustomResource> context) {
 
     var informerEventSource = new InformerEventSource<>(InformerConfiguration.from(

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/informereventsource/InformerEventSourceTestCustomReconciler.java

@@ -32,7 +32,7 @@ public class InformerEventSourceTestCustomReconciler
   private final AtomicInteger numberOfExecutions = new AtomicInteger(0);
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, InformerEventSourceTestCustomResource>> prepareEventSources(
       EventSourceContext<InformerEventSourceTestCustomResource> context) {
 
     InformerConfiguration<ConfigMap> config =

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/kubernetesdependentgarbagecollection/DependentGarbageCollectionTestReconciler.java

@@ -28,7 +28,7 @@ public DependentGarbageCollectionTestReconciler() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, DependentGarbageCollectionTestCustomResource>> prepareEventSources(
       EventSourceContext<DependentGarbageCollectionTestCustomResource> context) {
     return EventSourceUtils.dependentEventSources(context, configMapDependent);
   }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multipledependentresource/MultipleDependentResourceReconciler.java

@@ -33,7 +33,7 @@ public UpdateControl<MultipleDependentResourceCustomResource> reconcile(
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, MultipleDependentResourceCustomResource>> prepareEventSources(
       EventSourceContext<MultipleDependentResourceCustomResource> context) {
     InformerEventSource<ConfigMap, MultipleDependentResourceCustomResource> eventSource =
         new InformerEventSource<>(InformerConfiguration

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multipledependentresourcewithdiscriminator/MultipleDependentResourceWithDiscriminatorReconciler.java

@@ -43,7 +43,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, MultipleDependentResourceCustomResourceWithDiscriminator>> prepareEventSources(
       EventSourceContext<MultipleDependentResourceCustomResourceWithDiscriminator> context) {
     InformerEventSource<ConfigMap, MultipleDependentResourceCustomResourceWithDiscriminator> eventSource =
         new InformerEventSource<>(InformerConfiguration.from(ConfigMap.class,

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multipledrsametypenodiscriminator/MultipleManagedDependentSameTypeNoDiscriminatorReconciler.java

@@ -46,7 +46,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, MultipleManagedDependentNoDiscriminatorCustomResource>> prepareEventSources(
       EventSourceContext<MultipleManagedDependentNoDiscriminatorCustomResource> context) {
     InformerEventSource<ConfigMap, MultipleManagedDependentNoDiscriminatorCustomResource> ies =
         new InformerEventSource<>(

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplemanageddependentsametype/MultipleManagedDependentResourceReconciler.java

@@ -46,7 +46,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, MultipleManagedDependentResourceCustomResource>> prepareEventSources(
       EventSourceContext<MultipleManagedDependentResourceCustomResource> context) {
     InformerEventSource<ConfigMap, MultipleManagedDependentResourceCustomResource> ies =
         new InformerEventSource<>(

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplemanagedexternaldependenttype/MultipleManagedExternalDependentResourceReconciler.java

@@ -56,7 +56,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, MultipleManagedExternalDependentResourceCustomResource>> prepareEventSources(
       EventSourceContext<MultipleManagedExternalDependentResourceCustomResource> context) {
 
     final PollingEventSource.GenericResourceFetcher<ExternalResource> fetcher = () -> {

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplesecondaryeventsource/MultipleSecondaryEventSourceReconciler.java

@@ -61,7 +61,7 @@ public int getNumberOfExecutions() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, MultipleSecondaryEventSourceCustomResource>> prepareEventSources(
       EventSourceContext<MultipleSecondaryEventSourceCustomResource> context) {
 
     var config = InformerConfiguration

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/perresourceeventsource/PerResourcePollingEventSourceTestReconciler.java

@@ -34,7 +34,7 @@ public UpdateControl<PerResourceEventSourceCustomResource> reconcile(
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, PerResourceEventSourceCustomResource>> prepareEventSources(
       EventSourceContext<PerResourceEventSourceCustomResource> context) {
     PerResourcePollingEventSource<String, PerResourceEventSourceCustomResource> eventSource =
         new PerResourcePollingEventSource<>(String.class, context,

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primaryindexer/DependentPrimaryIndexerTestReconciler.java

@@ -30,7 +30,7 @@ public class DependentPrimaryIndexerTestReconciler extends AbstractPrimaryIndexe
   public static final String CONFIG_MAP_EVENT_SOURCE = "configMapEventSource";
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, PrimaryIndexerTestCustomResource>> prepareEventSources(
       EventSourceContext<PrimaryIndexerTestCustomResource> context) {
 
     var cache = context.getPrimaryCache();

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primaryindexer/PrimaryIndexerTestReconciler.java

@@ -16,7 +16,7 @@ public class PrimaryIndexerTestReconciler
     extends AbstractPrimaryIndexerTestReconciler {
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, PrimaryIndexerTestCustomResource>> prepareEventSources(
       EventSourceContext<PrimaryIndexerTestCustomResource> context) {
 
     context.getPrimaryCache().addIndexer(CONFIG_MAP_RELATION_INDEXER, indexer);

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primarytosecondary/JobReconciler.java

@@ -60,7 +60,7 @@ public UpdateControl<Job> reconcile(
   }
 
   @Override
-  public List<EventSource> prepareEventSources(EventSourceContext<Job> context) {
+  public List<EventSource<?, Job>> prepareEventSources(EventSourceContext<Job> context) {
     context.getPrimaryCache().addIndexer(JOB_CLUSTER_INDEX, (job -> List
         .of(indexKey(job.getSpec().getClusterName(), job.getMetadata().getNamespace()))));
 

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primarytosecondaydependent/PrimaryToSecondaryDependentReconciler.java

@@ -58,7 +58,7 @@ public int getNumberOfExecutions() {
    * demand for it.
    **/
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, PrimaryToSecondaryDependentCustomResource>> prepareEventSources(
       EventSourceContext<PrimaryToSecondaryDependentCustomResource> context) {
     // there is no owner reference in the config map, but we still want to trigger reconciliation if
     // the config map changes. So first we add an index which custom resource references the config

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/standalonedependent/StandaloneDependentTestReconciler.java

@@ -29,7 +29,7 @@ public StandaloneDependentTestReconciler() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(
+  public List<EventSource<?, StandaloneDependentTestCustomResource>> prepareEventSources(
       EventSourceContext<StandaloneDependentTestCustomResource> context) {
     return EventSourceUtils.dependentEventSources(context,
         deploymentDependent);

sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java

@@ -45,7 +45,7 @@ public WebappReconciler(KubernetesClient kubernetesClient) {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(EventSourceContext<Webapp> context) {
+  public List<EventSource<?, Webapp>> prepareEventSources(EventSourceContext<Webapp> context) {
     /*
      * To create an event to a related WebApp resource and trigger the reconciliation we need to
      * find which WebApp this Tomcat custom resource is related to. To find the related

sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageDependentsWorkflowReconciler.java

@@ -49,7 +49,7 @@ public WebPageDependentsWorkflowReconciler(KubernetesClient kubernetesClient) {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(EventSourceContext<WebPage> context) {
+  public List<EventSource<?, WebPage>> prepareEventSources(EventSourceContext<WebPage> context) {
     return EventSourceUtils.dependentEventSources(context, configMapDR,
         deploymentDR, serviceDR,
         ingressDR);

sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java

@@ -39,7 +39,7 @@ public WebPageReconciler() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(EventSourceContext<WebPage> context) {
+  public List<EventSource<?, WebPage>> prepareEventSources(EventSourceContext<WebPage> context) {
     var configMapEventSource =
         new InformerEventSource<>(InformerConfiguration.from(ConfigMap.class, WebPage.class)
             .withLabelSelector(SELECTOR)

sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageStandaloneDependentsReconciler.java

@@ -41,7 +41,7 @@ public WebPageStandaloneDependentsReconciler() {
   }
 
   @Override
-  public List<EventSource> prepareEventSources(EventSourceContext<WebPage> context) {
+  public List<EventSource<?, WebPage>> prepareEventSources(EventSourceContext<WebPage> context) {
     // initializes the dependents' event sources from the given context
     return EventSourceUtils.eventSourcesFromWorkflow(context, workflow);
   }