refactor: use jUnit 5 exception checking style

Author: metacosm

Diff for: operator-framework-core/src/test/java/io/javaoperatorsdk/operator/ControllerManagerTest.java

@@ -4,7 +4,7 @@
 
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.Operator.ControllerManager;
-import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
+import io.javaoperatorsdk.operator.api.ResourceController;
 import io.javaoperatorsdk.operator.api.config.DefaultControllerConfiguration;
 import io.javaoperatorsdk.operator.processing.ConfiguredController;
 import io.javaoperatorsdk.operator.sample.simple.DuplicateCRController;
@@ -13,31 +13,64 @@
 import io.javaoperatorsdk.operator.sample.simple.TestCustomResourceControllerV2;
 import io.javaoperatorsdk.operator.sample.simple.TestCustomResourceV2;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
 public class ControllerManagerTest {
 
-  @Test(expected = OperatorException.class)
+  @Test
   public void shouldNotAddMultipleControllersForSameCustomResource() {
-    final var controllerManager = new ControllerManager();
-    controllerManager
-        .add(new ConfiguredController<>(new TestCustomResourceController(null), config(
-            TestCustomResource.class), null));
-    controllerManager.add(new ConfiguredController<>(new DuplicateCRController(),
-        config(TestCustomResource.class), null));
+    final var registered = new TestControllerConfiguration<>(new TestCustomResourceController(null),
+        TestCustomResource.class);
+    final var duplicated =
+        new TestControllerConfiguration<>(new DuplicateCRController(), TestCustomResource.class);
+
+    checkException(registered, duplicated);
   }
 
-  @Test(expected = OperatorException.class)
+  @Test
   public void addingMultipleControllersForCustomResourcesWithDifferentVersionsShouldNotWork() {
-    final var controllerManager = new ControllerManager();
-    controllerManager
-        .add(new ConfiguredController<>(new TestCustomResourceController(null),
-            config(TestCustomResource.class), null));
-    controllerManager
-        .add(new ConfiguredController<>(new TestCustomResourceControllerV2(), config(
-            TestCustomResourceV2.class), null));
+    final var registered = new TestControllerConfiguration<>(new TestCustomResourceController(null),
+        TestCustomResource.class);
+    final var duplicated = new TestControllerConfiguration<>(new TestCustomResourceControllerV2(),
+        TestCustomResourceV2.class);
+
+    checkException(registered, duplicated);
+
   }
 
-  private <R extends CustomResource<?, ?>> ControllerConfiguration<R> config(Class<R> crClass) {
-    return new DefaultControllerConfiguration<>(null, crClass.getSimpleName() + "Controller",
-        CustomResource.getCRDName(crClass), null, false, null, null, null, null, crClass, null);
+  private <T extends CustomResource<?, ?>, U extends CustomResource<?, ?>> void checkException(
+      TestControllerConfiguration<T> registered,
+      TestControllerConfiguration<U> duplicated) {
+    final var exception = assertThrows(OperatorException.class, () -> {
+      final var controllerManager = new ControllerManager();
+      controllerManager.add(new ConfiguredController<>(registered.controller, registered, null));
+      controllerManager.add(new ConfiguredController<>(duplicated.controller, duplicated, null));
+    });
+    final var msg = exception.getMessage();
+    assertTrue(
+        msg.contains("Cannot register controller '" + duplicated.getControllerName() + "'")
+            && msg.contains(registered.getControllerName())
+            && msg.contains(registered.getCRDName()));
+  }
+
+  private static class TestControllerConfiguration<R extends CustomResource<?, ?>>
+      extends DefaultControllerConfiguration<R> {
+    private final ResourceController<R> controller;
+
+    public TestControllerConfiguration(ResourceController<R> controller, Class<R> crClass) {
+      super(null, getControllerName(controller),
+          CustomResource.getCRDName(crClass), null, false, null, null, null, null, crClass, null);
+      this.controller = controller;
+    }
+
+    static <R extends CustomResource<?, ?>> String getControllerName(
+        ResourceController<R> controller) {
+      return controller.getClass().getSimpleName() + "Controller";
+    }
+
+    private String getControllerName() {
+      return getControllerName(controller);
+    }
   }
 }