fix: multiple versions should actually not be supported

See #94

Author: metacosm

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

@@ -2,7 +2,6 @@
 
 import java.net.ConnectException;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -168,10 +167,6 @@ static class ControllerManager implements LifecycleAware {
     private final Map<String, ConfiguredController> controllers = new HashMap<>();
     private boolean started = false;
 
-    synchronized Map<String, ConfiguredController> getControllers() {
-      return Collections.unmodifiableMap(controllers);
-    }
-
     public synchronized void shouldStart() {
       if (started) {
         return;
@@ -202,15 +197,13 @@ public synchronized void stop() {
     public synchronized void add(ConfiguredController configuredController) {
       final var configuration = configuredController.getConfiguration();
       final var crdName = configuration.getCRDName();
-      final var version = configuration.getCustomResourceVersion();
-      final var key = crdName + "/" + version;
-      final var existing = controllers.get(key);
+      final var existing = controllers.get(crdName);
       if (existing != null) {
         throw new OperatorException("Cannot register controller '" + configuration.getName()
-            + "': another controller (" + existing.getConfiguration().getName()
-            + ") is already registered for CRD '" + crdName + "' (version: " + version + ")");
+            + "': another controller named '" + existing.getConfiguration().getName()
+            + "' is already registered for CRD '" + crdName + "'");
       }
-      this.controllers.put(key, configuredController);
+      this.controllers.put(crdName, configuredController);
       if (started) {
         configuredController.start();
       }

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfiguration.java

@@ -20,11 +20,7 @@ default String getName() {
   default String getCRDName() {
     return CustomResource.getCRDName(getCustomResourceClass());
   }
-
-  default String getCustomResourceVersion() {
-    return HasMetadata.getVersion(getCustomResourceClass());
-  }
-
+  
   default String getFinalizer() {
     return ControllerUtils.getDefaultFinalizerName(getCRDName());
   }

Diff for: operator-framework-core/src/test/java/io/javaoperatorsdk/operator/ControllerManagerTest.java

@@ -13,8 +13,6 @@
 import io.javaoperatorsdk.operator.sample.simple.TestCustomResourceControllerV2;
 import io.javaoperatorsdk.operator.sample.simple.TestCustomResourceV2;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
 public class ControllerManagerTest {
 
   @Test(expected = OperatorException.class)
@@ -27,17 +25,15 @@ public void shouldNotAddMultipleControllersForSameCustomResource() {
         config(TestCustomResource.class), null));
   }
 
-  @Test
-  public void addingMultipleControllersForCustomResourcesWithDifferentVersionsShouldWork() {
+  @Test(expected = OperatorException.class)
+  public void addingMultipleControllersForCustomResourcesWithDifferentVersionsShouldNotWork() {
     final var controllerManager = new ControllerManager();
     controllerManager
         .add(new ConfiguredController<>(new TestCustomResourceController(null),
             config(TestCustomResource.class), null));
     controllerManager
         .add(new ConfiguredController<>(new TestCustomResourceControllerV2(), config(
             TestCustomResourceV2.class), null));
-    final var controllers = controllerManager.getControllers();
-    assertEquals(2, controllers.size());
   }
 
   private <R extends CustomResource<?, ?>> ControllerConfiguration<R> config(Class<R> crClass) {