fix: allow keeping deleted CRDs in test with configuration

Signed-off-by: xstefank <[email protected]>

Author: xstefank

operator-framework-junit5/src/main/java/io/javaoperatorsdk/operator/junit/LocallyRunOperatorExtension.java

@@ -8,7 +8,9 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.time.Duration;
+import java.util.ArrayDeque;
 import java.util.ArrayList;
+import java.util.Deque;
 import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
@@ -43,6 +45,9 @@ public class LocallyRunOperatorExtension extends AbstractOperatorExtension {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(LocallyRunOperatorExtension.class);
   private static final int CRD_DELETE_TIMEOUT = 1000;
+  // Use Deque so we can keep deletion in LIFO order (stack)
+  private static final Deque<AppliedCRD> appliedCRDs = new ArrayDeque<>();
+  private static final boolean deleteCRDs = Boolean.parseBoolean(System.getProperty("testsuite.deleteCRDs", "true"));
 
   private final Operator operator;
   private final List<ReconcilerSpec> reconcilers;
@@ -51,7 +56,6 @@ public class LocallyRunOperatorExtension extends AbstractOperatorExtension {
   private final List<Class<? extends CustomResource>> additionalCustomResourceDefinitions;
   private final Map<Reconciler, RegisteredController> registeredControllers;
   private final Map<String, String> crdMappings;
-  private static final LinkedList<AppliedCRD> appliedCRDs = new LinkedList<>();
 
   private LocallyRunOperatorExtension(
       List<ReconcilerSpec> reconcilers,
@@ -148,7 +152,7 @@ private static void applyCrd(String crdString, String path, KubernetesClient cli
       LOGGER.debug("Applying CRD: {}", crdString);
       final var crd = client.load(new ByteArrayInputStream(crdString.getBytes()));
       crd.serverSideApply();
-      appliedCRDs.add(new AppliedCRD(crdString, path));
+      appliedCRDs.push(new AppliedCRD(crdString, path));
       Thread.sleep(CRD_READY_WAIT); // readiness is not applicable for CRD, just wait a little
       LOGGER.debug("Applied CRD with path: {}", path);
     } catch (InterruptedException ex) {
@@ -298,7 +302,7 @@ protected void after(ExtensionContext context) {
     var kubernetesClient = getKubernetesClient();
 
     while (!appliedCRDs.isEmpty()) {
-      deleteCrd(appliedCRDs.poll(), kubernetesClient);
+      deleteCrd(appliedCRDs.pop(), kubernetesClient);
     }
 
     kubernetesClient.close();
@@ -320,6 +324,10 @@ protected void after(ExtensionContext context) {
   }
 
   private void deleteCrd(AppliedCRD appliedCRD, KubernetesClient client) {
+    if (!deleteCRDs) {
+      LOGGER.debug("Skipping deleting CRD because of configuration: {}", appliedCRD);
+      return;
+    }
     try {
       LOGGER.debug("Deleting CRD: {}", appliedCRD.crdString);
       final var crd = client.load(new ByteArrayInputStream(appliedCRD.crdString.getBytes()));