Skip to content

Commit e99899a

Browse files
committed
feat: add factory method to init builder from an extising configuation
Signed-off-by: Chris Laprun <[email protected]>
1 parent 80c952f commit e99899a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ResourceConfiguration.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import java.util.Collections;
55
import java.util.Optional;
66
import java.util.Set;
7+
import java.util.stream.Collectors;
78

89
import io.fabric8.kubernetes.api.model.HasMetadata;
910
import io.fabric8.kubernetes.client.informers.cache.ItemStore;
@@ -103,7 +104,7 @@ static void failIfNotValid(Set<String> namespaces) {
103104

104105
static Set<String> ensureValidNamespaces(Collection<String> namespaces) {
105106
if (namespaces != null && !namespaces.isEmpty()) {
106-
return Set.copyOf(namespaces);
107+
return namespaces.stream().map(String::trim).collect(Collectors.toSet());
107108
} else {
108109
return Constants.DEFAULT_NAMESPACES_SET;
109110
}

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/InformerConfigHolder.java

+9
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,15 @@ public static <R extends HasMetadata> InformerConfigHolder<R>.Builder builder(
6666
return new InformerConfigHolder().builder;
6767
}
6868

69+
@SuppressWarnings({"rawtypes", "unchecked"})
70+
public static <R extends HasMetadata> InformerConfigHolder<R>.Builder builder(
71+
InformerConfigHolder<R> original) {
72+
return new InformerConfigHolder(original.name, original.namespaces,
73+
original.followControllerNamespacesOnChange, original.labelSelector, original.onAddFilter,
74+
original.onUpdateFilter, original.onDeleteFilter, original.genericFilter,
75+
original.itemStore, original.informerListLimit).builder;
76+
}
77+
6978
public String getName() {
7079
return name;
7180
}

0 commit comments

Comments
 (0)