fix: remove AbstractConfigurationService dependency on slf4j

Author: metacosm

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java

@@ -7,14 +7,8 @@
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Stream;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public abstract class AbstractConfigurationService implements ConfigurationService {
-
-  public static final String LOGGER_NAME = "Default ConfigurationService implementation";
-  protected static final Logger log = LoggerFactory.getLogger(LOGGER_NAME);
-
   private final Map<String, ControllerConfiguration> configurations = new ConcurrentHashMap<>();
   private final Version version;
 
@@ -60,12 +54,14 @@ public <R extends CustomResource> ControllerConfiguration<R> getConfigurationFor
     final var key = keyFor(controller);
     final var configuration = configurations.get(key);
     if (configuration == null) {
-      log.warn(
-          "Configuration for controller '{}' was not found. {}", key, getControllersNameMessage());
+      logMissingControllerWarning(key, getControllersNameMessage());
     }
     return configuration;
   }
 
+  protected abstract void logMissingControllerWarning(String controllerKey,
+      String controllersNameMessage);
+
   private String getControllersNameMessage() {
     return "Known controllers: "
         + getKnownControllerNames().stream().reduce((s, s2) -> s + ", " + s2).orElse("None")

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

@@ -1,8 +1,28 @@
 package io.javaoperatorsdk.operator.api.config;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class BaseConfigurationService extends AbstractConfigurationService {
 
+  private static final String LOGGER_NAME = "Default ConfigurationService implementation";
+  private static final Logger logger = LoggerFactory.getLogger(LOGGER_NAME);
+
   public BaseConfigurationService(Version version) {
     super(version);
   }
+
+  @Override
+  protected void logMissingControllerWarning(String controllerKey, String controllersNameMessage) {
+    logger.warn("Configuration for controller '{}' was not found. {}", controllerKey,
+        controllersNameMessage);
+  }
+
+  public String getLoggerName() {
+    return LOGGER_NAME;
+  }
+
+  protected Logger getLogger() {
+    return logger;
+  }
 }

Diff for: operator-framework/src/main/java/io/javaoperatorsdk/operator/config/runtime/DefaultConfigurationService.java

@@ -32,7 +32,7 @@ <R extends CustomResource> ControllerConfiguration<R> getConfigurationFor(
         // create the configuration on demand and register it
         config = new AnnotationConfiguration<>(controller);
         register(config);
-        log.info(
+        getLogger().info(
             "Created configuration for controller {} with name {}",
             controller.getClass().getName(),
             config.getName());

Diff for: operator-framework/src/test/java/io/javaoperatorsdk/operator/config/runtime/DefaultConfigurationServiceTest.java

@@ -28,6 +28,8 @@ public class DefaultConfigurationServiceTest {
 
   @Test
   void attemptingToRetrieveAnUnknownControllerShouldLogWarning() {
+    final var configurationService = DefaultConfigurationService.instance();
+
     final LoggerContext context = LoggerContext.getContext(false);
     final PatternLayout layout = PatternLayout.createDefaultLayout(context.getConfiguration());
     final ListAppender appender = new ListAppender("list", null, layout, false, false);
@@ -37,24 +39,25 @@ void attemptingToRetrieveAnUnknownControllerShouldLogWarning() {
     context.getConfiguration().addAppender(appender);
 
     AppenderRef ref = AppenderRef.createAppenderRef("list", null, null);
+    final var loggerName = configurationService.getLoggerName();
     LoggerConfig loggerConfig =
         LoggerConfig.createLogger(
             false,
             Level.valueOf("info"),
-            AbstractConfigurationService.LOGGER_NAME,
+            loggerName,
             "false",
             new AppenderRef[] {ref},
             null,
             context.getConfiguration(),
             null);
     loggerConfig.addAppender(appender, null, null);
 
-    context.getConfiguration().addLogger(AbstractConfigurationService.LOGGER_NAME, loggerConfig);
+    context.getConfiguration().addLogger(loggerName, loggerConfig);
     context.updateLoggers();
 
     try {
       final var config =
-          DefaultConfigurationService.instance()
+          configurationService
               .getConfigurationFor(new NotAutomaticallyCreated(), false);
 
       assertThat(config).isNull();
@@ -64,7 +67,7 @@ void attemptingToRetrieveAnUnknownControllerShouldLogWarning() {
     } finally {
       appender.stop();
 
-      context.getConfiguration().removeLogger(AbstractConfigurationService.LOGGER_NAME);
+      context.getConfiguration().removeLogger(loggerName);
       context.updateLoggers();
     }
   }