Skip to content

stopOnInformerErrorDuringStartup should not block application startup #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpozinen opened this issue Jun 7, 2023 · 2 comments · Fixed by #2024
Closed

stopOnInformerErrorDuringStartup should not block application startup #1934

dpozinen opened this issue Jun 7, 2023 · 2 comments · Fixed by #2024
Assignees

Comments

@dpozinen
Copy link

dpozinen commented Jun 7, 2023

Bug Report

What did you do?

set stopOnInformerErrorDuringStartup to false

the doc states that

if false, the startup will ignore recoverable errors, caused for example by RBAC issues, and will try to reconnect periodically in the background.

What did you expect to see?

The Spring Boot application would continue with startup, but attempt to start the Operator in the background

What did you see instead? Under which circumstances?

The Spring Boot application is prevented from starting while attempting to start the Operator.

Possible Solution

Likely some executor is not configured to respect this property.

@csviri csviri self-assigned this Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 7, 2023
@csviri csviri removed the stale label Aug 7, 2023
@csviri
Copy link
Collaborator

csviri commented Aug 22, 2023

So this seems to be not an issue, rather a feature, if you take a look on this PR:

#2024

What happens is that the operator eventually starts, but there is by default a quite hight timeout.

see this part of code:

https://github.com/java-operator-sdk/java-operator-sdk/blob/1691cf0b3e5df80749467aaa1a904221b2211ac6/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java#L81-L90

Basically it is hard to differentiate during the startup if it is because access right or just syncing is taking long. You can configure this timeout as seen in the PR.

Will discuss this with fabric8 team if we can improve on this. But will close the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants