Skip to content

Check Issues with SSA Matcher discovered in Keycloak #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Aug 7, 2023 · 2 comments · Fixed by #2028
Closed

Check Issues with SSA Matcher discovered in Keycloak #2000

csviri opened this issue Aug 7, 2023 · 2 comments · Fixed by #2028
Assignees

Comments

@csviri
Copy link
Collaborator

csviri commented Aug 7, 2023

see: keycloak/keycloak#22221

@shawkins
Copy link
Collaborator

shawkins commented Aug 9, 2023

Things like kubernetes/kubernetes#118519 and kubernetes/kubernetes#118519 (comment) are problematic for server side apply logic. The api server ends up creating extra revisions for changes that are otherwise not considered meaningful when performing client side apply or other patches. In particular the usage of secret stringdata is converted to data and empty strings in an Ingress are either pruned or converted to null. It appears those changes may cause an issue with the matching logic the operator has on the client side - that is it will make it appear like the desired state is different that the server state, but not in a way that is actually meaningful.

@csviri csviri linked a pull request Sep 14, 2023 that will close this issue
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 9, 2023
@csviri csviri closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants