Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set reconciliation timeout #2702

Open
csviri opened this issue Feb 24, 2025 · 1 comment
Open

Allow to set reconciliation timeout #2702

csviri opened this issue Feb 24, 2025 · 1 comment
Assignees
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Feb 24, 2025

Having a timeout for reconciliation could mitigate issues when because of some issue in the implementation, the reconciliation would be stuck, and would hold the thread forever.

This is something, that could be configured per controller bases.

Note that implementation wise this might be harder then it looks first, since currently the the thread that executes the reconcile also does some post processing, so this would require subtle changes in threading model.

@csviri csviri added this to the 5.1 milestone Feb 24, 2025
@csviri csviri self-assigned this Feb 24, 2025
@csviri
Copy link
Collaborator Author

csviri commented Mar 19, 2025

Wonder if we can do more than just interrupt the thread when timed out. And handle the interrupted threads also in the ReconciliationDispatcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant