Prevent Operator star/stop procedure be performed twice #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lburgazzoli opened this issue Aug 12, 2021 · 1 comment · Fixed by #491

Assignees

Collaborator

lburgazzoli commented Aug 12, 2021

As today the Operator start/stop methods do not have any barrier to avoid the methods to be invoked more than once and as example, since the introduction of the PR here https://github.com/quarkiverse/quarkus-operator-sdk/blob/main/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/StartupListener.java, I've observed that my operator did invoke start twice because I also had a startup listener to implement the same functionality.

I have now fixed my code so id does not happen anymore but I feel a barrier on the start/stop methods could be useful in any case.

laxmikantbpandhare assigned metacosm

snowdrop-bot mentioned this issue

Prevent Operator star/stop procedure be performed twice snowdrop-zen/java-operator-sdk#35

Closed

lburgazzoli mentioned this issue

feat: delay the registration of controller till the operator is started #491

Merged

Collaborator Author

lburgazzoli commented Aug 16, 2021

@metacosm pr #491 may address this issues

metacosm closed this as completed in #491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment