From 38225a76983a754dec668aaf31dce8d9814dd83f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= <a_meszaros@apple.com> Date: Mon, 31 Mar 2025 16:04:36 +0200 Subject: [PATCH 1/3] docs: explanation for max maxReconciliationInterval MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros <a_meszaros@apple.com> --- .../operator/api/reconciler/ControllerConfiguration.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java index 29bf0b670f..3b68b985b7 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java @@ -45,6 +45,9 @@ /** * Optional configuration of the maximal interval the SDK will wait for a reconciliation request * to happen before one will be automatically triggered. + * The intention behind this feature is to have a failsafe, not to have another way of + * repeated reconciliation. + * For that use {@link UpdateControl#rescheduleAfter(long)}. * * @return the maximal reconciliation interval configuration */ From 21c9899e944d1edc3bc93b5b5fc0312adca4191e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= <a_meszaros@apple.com> Date: Mon, 31 Mar 2025 16:06:17 +0200 Subject: [PATCH 2/3] fix format MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros <a_meszaros@apple.com> --- .../operator/api/reconciler/ControllerConfiguration.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java index 3b68b985b7..7195eac3ce 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java @@ -44,10 +44,9 @@ /** * Optional configuration of the maximal interval the SDK will wait for a reconciliation request - * to happen before one will be automatically triggered. - * The intention behind this feature is to have a failsafe, not to have another way of - * repeated reconciliation. - * For that use {@link UpdateControl#rescheduleAfter(long)}. + * to happen before one will be automatically triggered. The intention behind this feature is to + * have a failsafe, not to have another way of repeated reconciliation. For that use {@link + * UpdateControl#rescheduleAfter(long)}. * * @return the maximal reconciliation interval configuration */ From d2cce7229aed3557abe178263c939a33860a29ef Mon Sep 17 00:00:00 2001 From: Chris Laprun <metacosm@users.noreply.github.com> Date: Mon, 31 Mar 2025 16:16:21 +0200 Subject: [PATCH 3/3] refactor: improve wording --- .../operator/api/reconciler/ControllerConfiguration.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java index 7195eac3ce..d407ed0fc6 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java @@ -45,7 +45,7 @@ /** * Optional configuration of the maximal interval the SDK will wait for a reconciliation request * to happen before one will be automatically triggered. The intention behind this feature is to - * have a failsafe, not to have another way of repeated reconciliation. For that use {@link + * have a failsafe, not to artificially force repeated reconciliations. For that use {@link * UpdateControl#rescheduleAfter(long)}. * * @return the maximal reconciliation interval configuration