Address reviewer comments

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

hack/demo/resources/synthetic-user-perms/argocd-clusterextension.yaml

@@ -10,4 +10,4 @@ spec:
     sourceType: Catalog
     catalog:
       packageName: argocd-operator
-      version: 0.6.0
+      version: 0.6.0

hack/demo/resources/synthetic-user-perms/cegroup-admin-binding.yaml

@@ -8,4 +8,4 @@ roleRef:
   name: cluster-admin
 subjects:
   - kind: Group
-    name: "olm:clusterextensions"
+    name: "olm:clusterextensions"

internal/operator-controller/authentication/synthetic.go

@@ -9,13 +9,12 @@ import (
 )
 
 func syntheticUserName(ext ocv1.ClusterExtension) string {
-	return fmt.Sprintf("olm:clusterextensions:%s", ext.Name)
+	return fmt.Sprintf("olm:clusterextension:%s", ext.Name)
 }
 
 func syntheticGroups(_ ocv1.ClusterExtension) []string {
 	return []string{
 		"olm:clusterextensions",
-		"system:authenticated",
 	}
 }
 

internal/operator-controller/authentication/synthetic_test.go

@@ -16,10 +16,9 @@ func TestSyntheticImpersonationConfig(t *testing.T) {
 			Name: "my-ext",
 		},
 	})
-	require.Equal(t, "olm:clusterextensions:my-ext", config.UserName)
+	require.Equal(t, "olm:clusterextension:my-ext", config.UserName)
 	require.Equal(t, []string{
 		"olm:clusterextensions",
-		"system:authenticated",
 	}, config.Groups)
 	require.Empty(t, config.UID)
 	require.Empty(t, config.Extra)