Skip to content

Commit 38da6fc

Browse files
authored
Remove deploy CI job (#691)
We test deployment in our E2E job and maintaining a separate job to test application of CRDs is additional overhead we can avoid. Signed-off-by: Mikalai Radchuk <[email protected]>
1 parent 6865e1d commit 38da6fc

File tree

2 files changed

+1
-46
lines changed

2 files changed

+1
-46
lines changed

.github/workflows/deploy.yaml

-29
This file was deleted.

Makefile

+1-17
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ build-push-e2e-catalog: ## Build the testdata catalog used for e2e tests and pus
141141
test-e2e: KIND_CLUSTER_NAME=operator-controller-e2e
142142
test-e2e: KUSTOMIZE_BUILD_DIR=config/e2e
143143
test-e2e: GO_BUILD_FLAGS=-cover
144-
test-e2e: run image-registry build-push-e2e-catalog kind-load-test-artifacts e2e e2e-coverage undeploy kind-clean #HELP Run e2e test suite on local kind cluster
144+
test-e2e: run image-registry build-push-e2e-catalog kind-load-test-artifacts e2e e2e-coverage kind-clean #HELP Run e2e test suite on local kind cluster
145145

146146
.PHONY: extension-developer-e2e
147147
extension-developer-e2e: KIND_CLUSTER_NAME=operator-controller-ext-dev-e2e #EXHELP Run extension-developer e2e on local kind cluster
@@ -233,22 +233,6 @@ quickstart: $(KUSTOMIZE) manifests #EXHELP Generate the installation release man
233233
$(KUSTOMIZE) build $(KUSTOMIZE_BUILD_DIR) | sed "s/:devel/:$(VERSION)/g" > operator-controller.yaml
234234
envsubst '$$CATALOGD_VERSION,$$CERT_MGR_VERSION,$$KAPP_VERSION,$$RUKPAK_VERSION,$$MANIFEST' < scripts/install.tpl.sh > install.sh
235235

236-
#SECTION Deployment
237-
238-
ifndef ignore-not-found
239-
ignore-not-found = false
240-
endif
241-
242-
.PHONY: deploy
243-
deploy: manifests $(KUSTOMIZE) #HELP Deploy controller to the K8s cluster specified in ~/.kube/config.
244-
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
245-
$(KUSTOMIZE) build $(KUSTOMIZE_BUILD_DIR) | kubectl apply -f -
246-
247-
.PHONY: undeploy
248-
undeploy: #HELP Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.
249-
$(KUSTOMIZE) build $(KUSTOMIZE_BUILD_DIR) | kubectl delete --ignore-not-found=$(ignore-not-found) -f -
250-
251-
252236
##@ Docs
253237

254238
VENVDIR=$(abspath docs/.venv)

0 commit comments

Comments
 (0)