Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalogd web api unit test misc fixes #1709

Closed
Tracked by #1570
grokspawn opened this issue Feb 5, 2025 · 1 comment · Fixed by #1720
Closed
Tracked by #1570

catalogd web api unit test misc fixes #1709

grokspawn opened this issue Feb 5, 2025 · 1 comment · Fixed by #1720
Assignees

Comments

@grokspawn
Copy link
Contributor

with the new API, there are a couple of things we missed during review around the unit tests that we need to take care of

  1. response body format for all catalogd web endpoints is jsonlines, and we used to have a test that enforced this was consistent. It was removed and we need to restore it so that if our "happy accident" that created JSONL-by-default encoding here ever changes, we can adjust as soon as the dependency bumps
  2. rename http_precoditions_check.go --> http_preconditions_check.go
  3. remove suite_test.go since there are no longer any ginkgo tests in the suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants