Fix flaky TestUpdates unit test

cblecker · cblecker · commit 0084d61a0887 · 2022-12-05T08:00:07.000-08:00
Signed-off-by: Christoph Blecker &lt;cblecker@redhat.com&gt;
diff --git a/pkg/controller/operators/olm/operator_test.go b/pkg/controller/operators/olm/operator_test.go
@@ -3923,9 +3923,10 @@ func TestUpdates(t *testing.T) {
 					simulateSuccessfulRollout(current, op.opClient)
 				}
 				for current.Status.Phase != e.whenIn.phase {
-					fmt.Printf("waiting for (when) %s to be %s\n", e.whenIn.name, e.whenIn.phase)
 					csvsToSync = syncCSVs(csvsToSync, deletedCSVs(e.shouldBe))
 					current = csvsToSync[e.whenIn.name]
+					fmt.Printf("waiting for (when) %s to be %s\n", e.whenIn.name, e.whenIn.phase)
+					time.Sleep(1 * time.Millisecond)
 				}
 
 				// sync the other csvs until they're in the expected status

Original file line number	Diff line number	Diff line change
`@@ -3923,9 +3923,10 @@ func TestUpdates(t *testing.T) {`
`3923`	`3923`	`simulateSuccessfulRollout(current, op.opClient)`
`3924`	`3924`	`}`
`3925`	`3925`	`for current.Status.Phase != e.whenIn.phase {`
`3926`		`- fmt.Printf("waiting for (when) %s to be %s\n", e.whenIn.name, e.whenIn.phase)`
`3927`	`3926`	`csvsToSync = syncCSVs(csvsToSync, deletedCSVs(e.shouldBe))`
`3928`	`3927`	`current = csvsToSync[e.whenIn.name]`
	`3928`	`+ fmt.Printf("waiting for (when) %s to be %s\n", e.whenIn.name, e.whenIn.phase)`
	`3929`	`+ time.Sleep(1 * time.Millisecond)`
`3929`	`3930`	`}`
`3930`	`3931`
`3931`	`3932`	`// sync the other csvs until they're in the expected status`