.github: Separate the golangci-lint step into it's own job

As advertised in the action's official documentation, it's easier to
separate this action into it's own job so it can run in parallel with
other jobs defined within an individual workflow. When removing this
flag in the previous commit, the action was silently failing as it
couldn't access the go module package cache due to what appeared to be
permissions-related failures. Moving the golangci-lint action to it's
own job fixed those silent failures.

Signed-off-by: timflannagan <[email protected]>

Author: timflannagan

.github/workflows/sanity.yaml

@@ -6,17 +6,20 @@ on:
   pull_request:
   workflow_dispatch:
 jobs:
-  sanity:
+  vendor:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/setup-go@v2
-        with:
-          go-version: '~1.17'
-      - name: Run sanity checks
-        run: make vendor && make diff
-      - name: Run linting checks
-        uses: "golangci/golangci-lint-action@v2"
-        with:
-          version: "v1.43"
-          skip-go-installation: true
+    - uses: actions/checkout@v1
+    - uses: actions/setup-go@v2
+      with:
+        go-version: '~1.17'
+    - name: Run sanity checks
+      run: make vendor && make diff
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Run linting checks
+      uses: "golangci/golangci-lint-action@v2"
+      with:
+        version: "v1.43"