Skip to content

Commit 32dc717

Browse files
simonpasquierperdasilva
authored andcommitted
OCPBUGS-8993: add namespace label to InstallPlanStepAppliedWithWarnings
The alerting consistency guide [1] requires the following: `Alerts SHOULD include a namespace label indicating the alert's source.` This change updates the expression of InstallPlanStepAppliedWithWarnings to aggregate the result by namespace. [1] https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/alerting-consistency.md Signed-off-by: Simon Pasquier <[email protected]>
1 parent 12437b3 commit 32dc717

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

deploy/chart/templates/0000_90_olm_01-prometheus-rule.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ spec:
3434
- name: olm.installplan.rules
3535
rules:
3636
- alert: InstallPlanStepAppliedWithWarnings
37-
expr: sum(increase(installplan_warnings_total[5m])) > 0
37+
expr: sum by(namespace) (increase(installplan_warnings_total[5m])) > 0
3838
labels:
3939
severity: warning
4040
annotations:

0 commit comments

Comments
 (0)