Skip to content

Commit 480e621

Browse files
authoredJun 1, 2022
Update PR template (#2787)
Signed-off-by: perdasilva <[email protected]>
1 parent dd06812 commit 480e621

File tree

1 file changed

+21
-3
lines changed

1 file changed

+21
-3
lines changed
 

‎.github/PULL_REQUEST_TEMPLATE.md

+21-3
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,35 @@ Note: Make sure your branch is rebased to the latest upstream master.
88

99
**Description of the change:**
1010

11-
1211
**Motivation for the change:**
1312

13+
**Architectural changes:**
14+
15+
<!--
16+
If necessary, briefly describe any architectural changes, other options considered, and/or link to any EPs or design docs
17+
-->
18+
19+
**Testing remarks:**
20+
21+
<!--
22+
Call out any information around how you've tested the code change that may be useful for reviewers. For instance:
23+
* any edge-cases you have (dis)covered
24+
* how you have reproduced and tested for regressions in bug fixes
25+
* how you've tested for flakes in e2e tests or flake fixes
26+
-->
27+
1428
**Reviewer Checklist**
1529
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
1630
- [ ] Sufficient unit test coverage
1731
- [ ] Sufficient end-to-end test coverage
32+
- [ ] Bug fixes are accompanied by regression test(s)
33+
- [ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
34+
- [ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
35+
- [ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
1836
- [ ] Docs updated or added to `/doc`
1937
- [ ] Commit messages sensible and descriptive
20-
- [ ] Tests marked as `[FLAKE]` are truly flaky
21-
- [ ] Tests that remove the `[FLAKE]` tag are no longer flaky
38+
- [ ] Tests marked as `[FLAKE]` are truly flaky and have an issue
39+
- [ ] Code is properly formatted
2240

2341

2442
<!--

0 commit comments

Comments
 (0)
Please sign in to comment.