@@ -8,17 +8,35 @@ Note: Make sure your branch is rebased to the latest upstream master.
8
8
9
9
** Description of the change:**
10
10
11
-
12
11
** Motivation for the change:**
13
12
13
+ ** Architectural changes:**
14
+
15
+ <!--
16
+ If necessary, briefly describe any architectural changes, other options considered, and/or link to any EPs or design docs
17
+ -->
18
+
19
+ ** Testing remarks:**
20
+
21
+ <!--
22
+ Call out any information around how you've tested the code change that may be useful for reviewers. For instance:
23
+ * any edge-cases you have (dis)covered
24
+ * how you have reproduced and tested for regressions in bug fixes
25
+ * how you've tested for flakes in e2e tests or flake fixes
26
+ -->
27
+
14
28
** Reviewer Checklist**
15
29
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
16
30
- [ ] Sufficient unit test coverage
17
31
- [ ] Sufficient end-to-end test coverage
32
+ - [ ] Bug fixes are accompanied by regression test(s)
33
+ - [ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
34
+ - [ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
35
+ - [ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
18
36
- [ ] Docs updated or added to ` /doc `
19
37
- [ ] Commit messages sensible and descriptive
20
- - [ ] Tests marked as ` [FLAKE] ` are truly flaky
21
- - [ ] Tests that remove the ` [FLAKE] ` tag are no longer flaky
38
+ - [ ] Tests marked as ` [FLAKE] ` are truly flaky and have an issue
39
+ - [ ] Code is properly formatted
22
40
23
41
24
42
<!--
0 commit comments