use snake case for catalogsource_ready metric

Author: anik120

pkg/metrics/metrics.go

@@ -144,7 +144,7 @@ var (
 
 	catalogSourceReady = prometheus.NewGaugeVec(
 		prometheus.GaugeOpts{
-			Name: "catalogSource_ready",
+			Name: "catalogsource_ready",
 			Help: "State of a CatalogSource. 1 indicates that the CatalogSource is in a READY state. 0 indicates CatalogSource is in a Non READY state.",
 		},
 		[]string{NAMESPACE_LABEL, NAME_LABEL},

test/e2e/metrics_e2e_test.go

@@ -316,7 +316,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
 						WithValueGreaterThan(0),
 					)),
 					ContainElement(LikeMetric(
-						WithFamily("catalogSource_ready"),
+						WithFamily("catalogsource_ready"),
 						WithName(name),
 						WithNamespace(testNamespace),
 						WithValue(1),
@@ -332,7 +332,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
 						return getMetricsFromPod(c, getPodWithLabel(c, "app=catalog-operator"), "8081")
 					}).Should(And(
 						Not(ContainElement(LikeMetric(
-							WithFamily("catalogSource_ready"),
+							WithFamily("catalogsource_ready"),
 							WithName(name),
 							WithNamespace(testNamespace),
 						)))))
@@ -356,7 +356,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
 					return getMetricsFromPod(c, getPodWithLabel(c, "app=catalog-operator"), "8081")
 				}).Should(And(
 					ContainElement(LikeMetric(
-						WithFamily("catalogSource_ready"),
+						WithFamily("catalogsource_ready"),
 						WithName(name),
 						WithNamespace(testNamespace),
 						WithValue(0),
@@ -366,7 +366,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
 					return getMetricsFromPod(c, getPodWithLabel(c, "app=catalog-operator"), "8081")
 				}, "3m").Should(And(
 					ContainElement(LikeMetric(
-						WithFamily("catalogSource_ready"),
+						WithFamily("catalogsource_ready"),
 						WithName(name),
 						WithNamespace(testNamespace),
 						WithValue(0),