Skip to content

Commit 8a31e33

Browse files
committed
Reduce CSV e2e test failure rate
1 parent e2b51e2 commit 8a31e33

File tree

1 file changed

+24
-10
lines changed

1 file changed

+24
-10
lines changed

test/e2e/csv_e2e_test.go

+24-10
Original file line numberDiff line numberDiff line change
@@ -1306,28 +1306,42 @@ var _ = Describe("ClusterServiceVersion", func() {
13061306
Expect(err).ShouldNot(HaveOccurred(), "error getting expected APIService")
13071307

13081308
// Should create Service
1309-
_, err = c.GetService(testNamespace, serviceName)
1310-
Expect(err).ShouldNot(HaveOccurred(), "error getting expected Service")
1309+
Eventually(func() error {
1310+
_, err := c.GetService(testNamespace, serviceName)
1311+
return err
1312+
}, timeout, interval).ShouldNot(HaveOccurred())
13111313

13121314
// Should create certificate Secret
13131315
secretName = fmt.Sprintf("%s-cert", serviceName)
1314-
_, err = c.GetSecret(testNamespace, secretName)
1315-
Expect(err).ShouldNot(HaveOccurred(), "error getting expected Secret")
1316+
Eventually(func() error {
1317+
_, err = c.GetSecret(testNamespace, secretName)
1318+
return err
1319+
}, timeout, interval).ShouldNot(HaveOccurred())
13161320

13171321
// Should create a Role for the Secret
13181322
_, err = c.GetRole(testNamespace, secretName)
1319-
Expect(err).ShouldNot(HaveOccurred(), "error getting expected Secret Role")
1323+
Eventually(func() error {
1324+
_, err = c.GetRole(testNamespace, secretName)
1325+
return err
1326+
}, timeout, interval).ShouldNot(HaveOccurred())
13201327

13211328
// Should create a RoleBinding for the Secret
1322-
_, err = c.GetRoleBinding(testNamespace, secretName)
1323-
Expect(err).ShouldNot(HaveOccurred(), "error getting exptected Secret RoleBinding")
1329+
Eventually(func() error {
1330+
_, err = c.GetRoleBinding(testNamespace, secretName)
1331+
return err
1332+
}, timeout, interval).ShouldNot(HaveOccurred())
13241333

13251334
// Should create a system:auth-delegator Cluster RoleBinding
1326-
_, err = c.GetClusterRoleBinding(fmt.Sprintf("%s-system:auth-delegator", serviceName))
1327-
Expect(err).ShouldNot(HaveOccurred(), "error getting expected system:auth-delegator ClusterRoleBinding")
1335+
Eventually(func() error {
1336+
_, err = c.GetClusterRoleBinding(fmt.Sprintf("%s-system:auth-delegator", serviceName))
1337+
return err
1338+
}, timeout, interval).ShouldNot(HaveOccurred())
13281339

13291340
// Should create an extension-apiserver-authentication-reader RoleBinding in kube-system
1330-
_, err = c.GetRoleBinding("kube-system", fmt.Sprintf("%s-auth-reader", serviceName))
1341+
Eventually(func() error {
1342+
_, err = c.GetRoleBinding("kube-system", fmt.Sprintf("%s-auth-reader", serviceName))
1343+
return err
1344+
}, timeout, interval).ShouldNot(HaveOccurred())
13311345
Expect(err).ShouldNot(HaveOccurred(), "error getting expected extension-apiserver-authentication-reader RoleBinding")
13321346

13331347
// Should eventually GC the CSV

0 commit comments

Comments
 (0)