Address Tim's feedback

Author: awgreene

test/e2e/installplan_e2e_test.go

@@ -3281,10 +3281,6 @@ var _ = Describe("Install Plan", func() {
 
 			catsrcName = catsrc.GetName()
 
-			// Wait for the CatalogSource to be ready
-			_, err := fetchCatalogSourceOnStatus(newCRClient(), catsrc.GetName(), catsrc.GetNamespace(), catalogSourceRegistryPodSynced)
-			Expect(err).ToNot(HaveOccurred())
-
 			// Create the OperatorGroup
 			og := &operatorsv1.OperatorGroup{
 				ObjectMeta: metav1.ObjectMeta{

test/e2e/subscription_e2e_test.go

@@ -847,8 +847,8 @@ var _ = Describe("Subscription", func() {
 						Expect(err).ToNot(HaveOccurred())
 					}()
 
-					// Wait for the CatalogSource to be ready
-					_, err = fetchCatalogSourceOnStatus(crc, cs.GetName(), cs.GetNamespace(), catalogSourceRegistryPodSynced)
+					// Wait for the CatalogSource status to be updated to reflect its invalid spec
+					_, err = fetchCatalogSourceOnStatus(crc, cs.GetName(), cs.GetNamespace(), catalogSourceInvalidSpec)
 					Expect(err).ToNot(HaveOccurred(), "catalog source did not become ready")
 
 					subName := genName("sub-")

test/e2e/util_test.go

@@ -325,6 +325,10 @@ func catalogSourceRegistryPodSynced(catalog *v1alpha1.CatalogSource) bool {
 	return false
 }
 
+func catalogSourceInvalidSpec(catalog *v1alpha1.CatalogSource) bool {
+	return catalog.Status.Reason == v1alpha1.CatalogSourceSpecInvalidError
+}
+
 func fetchCatalogSourceOnStatus(crc versioned.Interface, name, namespace string, check catalogSourceCheckFunc) (*v1alpha1.CatalogSource, error) {
 	var fetched *v1alpha1.CatalogSource
 	var err error