Skip to content

Commit cc5d1d1

Browse files
author
Per Goncalves da Silva
committed
fix crd data loss e2e test
1 parent 9ef6771 commit cc5d1d1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: test/e2e/crd_e2e_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,7 @@ var _ = Describe("CRD Versions", func() {
114114
Expect(fetchedInstallPlan.Status.Phase).To(Equal(operatorsv1alpha1.InstallPlanPhaseComplete))
115115
})
116116

117-
// issue:https://github.com/operator-framework/operator-lifecycle-manager/issues/2638
118-
It("[FLAKE] blocks a CRD upgrade that could cause data loss", func() {
117+
It("blocks a CRD upgrade that could cause data loss", func() {
119118
By("checking the storage versions in the existing CRD status and the spec of the new CRD")
120119

121120
mainPackageName := genName("nginx-update2-")
@@ -275,7 +274,8 @@ var _ = Describe("CRD Versions", func() {
275274
By("Check the error on the installplan - should be related to data loss and the CRD upgrade missing a stored version")
276275
Eventually(func() (*operatorsv1alpha1.InstallPlan, error) {
277276
return crc.OperatorsV1alpha1().InstallPlans(generatedNamespace.GetName()).Get(context.TODO(), s.Status.InstallPlanRef.Name, metav1.GetOptions{})
278-
}).Should(And(
277+
// the install plan retry time out is 60 seconds, so we should expect the install plan to be failed within 2 minutes
278+
}).Within(2 * time.Minute).Should(And(
279279
WithTransform(
280280
func(v *operatorsv1alpha1.InstallPlan) operatorsv1alpha1.InstallPlanPhase {
281281
return v.Status.Phase

0 commit comments

Comments
 (0)