use sets to track certs to install

Signed-off-by: Ankita Thomas <[email protected]>

Author: ankitathomas

Diff for: pkg/controller/install/certresources.go

@@ -12,6 +12,7 @@ import (
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
+	"k8s.io/apimachinery/pkg/util/sets"
 	corev1ac "k8s.io/client-go/applyconfigurations/core/v1"
 	rbacv1ac "k8s.io/client-go/applyconfigurations/rbac/v1"
 
@@ -274,15 +275,15 @@ func shouldRotateCerts(certSecret *corev1.Secret, hosts []string) bool {
 func (i *StrategyDeploymentInstaller) ShouldRotateCerts(s Strategy) (bool, error) {
 	strategy, ok := s.(*v1alpha1.StrategyDetailsDeployment)
 	if !ok {
-		return false, fmt.Errorf("attempted to install %s strategy with deployment installer", strategy.GetStrategyName())
+		return false, fmt.Errorf("failed to install %s strategy with deployment installer: unsupported deployment install strategy", strategy.GetStrategyName())
 	}
 
-	hasCerts := map[string]struct{}{}
+	hasCerts := sets.NewString()
 	for _, c := range i.getCertResources() {
-		hasCerts[c.getDeploymentName()] = struct{}{}
+		hasCerts.Insert(c.getDeploymentName())
 	}
 	for _, sddSpec := range strategy.DeploymentSpecs {
-		if _, ok := hasCerts[sddSpec.Name]; ok {
+		if hasCerts.Has(sddSpec.Name) {
 			certSecret, err := i.strategyClient.GetOpLister().CoreV1().SecretLister().Secrets(i.owner.GetNamespace()).Get(SecretName(ServiceName(sddSpec.Name)))
 			if err == nil {
 				if shouldRotateCerts(certSecret, HostnamesForService(ServiceName(sddSpec.Name), i.owner.GetNamespace())) {