Add break in crd garbage collection loop

Signed-off-by: perdasilva <[email protected]>

Author: perdasilva

Diff for: test/e2e/util/e2e_client.go

@@ -93,6 +93,7 @@ func (m *E2EKubeClient) GarbageCollectCRDs() error {
 				if err := m.Client.Delete(context.Background(), &crd); err != nil {
 					return err
 				}
+				break
 			}
 		}
 	}

Diff for: test/e2e/util/e2e_subscription_helper.go

@@ -2,7 +2,6 @@ package util
 
 import (
 	"context"
-	"encoding/json"
 
 	"github.com/operator-framework/api/pkg/operators/v1alpha1"
 	k8scontrollerclient "sigs.k8s.io/controller-runtime/pkg/client"
@@ -29,7 +28,7 @@ func (s *SubscriptionHelper) EventuallyContainsCondition(expectedCondition v1alp
 				return nil
 			}
 		}
-		return LogAndFormatError("expected subscription condition %s to be in %s", expectedCondition, subscription.Status.Conditions)
+		return LogAndFormatError("expected subscription condition %s to be in %s", expectedCondition, ObjectToJsonString(subscription.Status.Conditions))
 	})
 }
 
@@ -57,8 +56,3 @@ func (s *SubscriptionHelper) waitForSubscriptionToBeLike(checkerFn func(subscrip
 		return checkerFn(subscription)
 	})
 }
-
-func objectToYamlString(obj interface{}) string {
-	data, _ := json.Marshal(obj)
-	return string(data)
-}

Diff for: test/e2e/util/test_logging.go

@@ -1,6 +1,7 @@
 package util
 
 import (
+	"encoding/json"
 	"fmt"
 	"strings"
 
@@ -18,3 +19,8 @@ func LogAndFormatError(format string, args ...interface{}) error {
 	Logf(format, args...)
 	return fmt.Errorf(format, args...)
 }
+
+func ObjectToJsonString(obj interface{}) string {
+	data, _ := json.Marshal(obj)
+	return string(data)
+}