Fix regexp in sanity check for log message case (#913)

* pkg/*: fix test log message cases

* hack/check_error_log_msg_format.sh: fix log case regexp to match anything but "fmt.Error(f)?.*"

Author: estroz

Diff for: hack/check_error_log_msg_format.sh

@@ -7,7 +7,7 @@ source "hack/lib/test_lib.sh"
 
 echo "Checking format of error and log messages..."
 allfiles=$(listFiles)
-log_case_output=$(grep -ERn '(Error\((.*[Ee]rr|nil), |[^(fmt\.)]Error(f)?\(|Fatal(f)?\(|Info(f)?\(|Warn(f)?\()"[[:lower:]]' $allfiles | sort -u)
+log_case_output=$(grep -PRn '(Error\((.*[Ee]rr|nil), |^(?!.*fmt).+\.Error(f)?\(|Fatal(f)?\(|Info(f)?\(|Warn(f)?\()"[[:lower:]]' $allfiles | sort -u)
 if [ -n "${log_case_output}" ]; then
   echo -e "Log messages do not begin with upper case:\n${log_case_output}"
 fi

Diff for: pkg/k8sutil/k8sutil_test.go

@@ -68,7 +68,7 @@ func TestGetOperatorName(t *testing.T) {
 		_ = os.Setenv(test.envVarKey, test.envVarValue)
 		operatorName, err := GetOperatorName()
 		if !(operatorName == test.expectedOutput.operatorName && reflect.DeepEqual(err, test.expectedOutput.err)) {
-			t.Errorf("test %s failed, expected ouput: %s,%v; got: %s,%v", test.name, test.expectedOutput.operatorName, test.expectedOutput.err, operatorName, err)
+			t.Errorf("Test %s failed, expected ouput: %s,%v; got: %s,%v", test.name, test.expectedOutput.operatorName, test.expectedOutput.err, operatorName, err)
 		}
 		_ = os.Unsetenv(test.envVarKey)
 	}

Diff for: pkg/ready/ready_test.go

@@ -23,24 +23,24 @@ func TestFileReady(t *testing.T) {
 	r := NewFileReady()
 	err := r.Set()
 	if err != nil {
-		t.Errorf("could not set ready file: %v", err)
+		t.Errorf("Could not set ready file: %v", err)
 	}
 
 	_, err = os.Stat(FileName)
 	if err != nil {
-		t.Errorf("did not find expected file at %s: %v", FileName, err)
+		t.Errorf("Did not find expected file at %s: %v", FileName, err)
 	}
 
 	err = r.Unset()
 	if err != nil {
-		t.Errorf("could not unset ready file: %v", err)
+		t.Errorf("Could not unset ready file: %v", err)
 	}
 
 	_, err = os.Stat(FileName)
 	if err == nil {
-		t.Errorf("file still exists at %s", FileName)
+		t.Errorf("File still exists at %s", FileName)
 	}
 	if !os.IsNotExist(err) {
-		t.Errorf("error determining if file still exists at %s: %v", FileName, err)
+		t.Errorf("Error determining if file still exists at %s: %v", FileName, err)
 	}
 }