Skip to content

Do not expose commands/operator-sdk/cmd #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joelanford opened this issue Mar 7, 2019 · 1 comment · Fixed by #1185
Closed

Do not expose commands/operator-sdk/cmd #1184

joelanford opened this issue Mar 7, 2019 · 1 comment · Fixed by #1185
Assignees
@joelanford

Comments

@joelanford
Copy link
Member

Problem
Users are not going to need commands/operator-sdk/cmd as a library, so it should not be exported.

Proposed fix
Move commands/operator-sdk/cmd -> commands/operator-sdk/internal/cmd
@joelanford joelanford added this to the 1.0.0 milestone Mar 7, 2019
@joelanford joelanford self-assigned this Mar 7, 2019
@joelanford joelanford mentioned this issue Mar 7, 2019
Merged
@jmrodri
Copy link
Member

jmrodri commented Mar 21, 2019

Do we have a huge problem of people using code in this project? I've never really seen things in internal until this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelanford joelanford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

commands/operator-sdk: rename to cmd/operator-sdk and reorganize joelanford/operator-sdk
2 participants
@jmrodri @joelanford